fix: guard ARM-specific code behind NORNS_DESKTOP for x86 desktop builds#1876
fix: guard ARM-specific code behind NORNS_DESKTOP for x86 desktop builds#1876renderorange wants to merge 1 commit intomonome:mainfrom
Conversation
The --desktop build mode was incomplete: ssd1322.c (NEON intrinsics), gpio.c, and -mfpu=neon were always compiled, breaking x86_64 builds. Properly exclude ARM hardware drivers and flags when building for desktop.
tehn
left a comment
There was a problem hiding this comment.
Thanks for looking into this.
Would it not be simpler and cleaner to instead put all of the defines inside of ssd1322.c? So all the includes could stay, functions could get called but they'd just be returned.
Have you had success running the desktop build?
yeah, happy to work on those changes. I'll try to get into it over this coming weekend.
yup, it seems to have built fine. I'm not entirely sure my hacky attempt at enabling the keyboard controls were correct, so didn't get to test it out extensively. I got the interface to load and could move around, minimally. as for manipulating input sound, I didn't get that far. |
The --desktop build mode was incomplete: ssd1322.c (NEON intrinsics), gpio.c, and -mfpu=neon were always compiled, breaking x86_64 builds. Properly exclude ARM hardware drivers and flags when building for desktop.