Change this & window reference to a global passed in closure#2630
Open
SergioCrisostomo wants to merge 1 commit intomootools:masterfrom
Open
Change this & window reference to a global passed in closure#2630SergioCrisostomo wants to merge 1 commit intomootools:masterfrom
global passed in closure#2630SergioCrisostomo wants to merge 1 commit intomootools:masterfrom
Conversation
to improve obfuscation and prepare for the future
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #2413
Use global inside closures to improve obfuscation and prepare for the future.
P.S.: A bit scary to change so many references...
I ran the specs on this and got all green, but would feel good with some pairs of human eyes looking at the changes...