stripScripts now loads & executes external files#2691
Open
ickata wants to merge 1 commit intomootools:masterfrom
Open
stripScripts now loads & executes external files#2691ickata wants to merge 1 commit intomootools:masterfrom
ickata wants to merge 1 commit intomootools:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small change to
String.stripScriptswith major improvement - it also injects & executes external JS files. All JavaScript is executed synchronously, in order to preserve dependency.Two new arguments are passed to the
execfunction:Arrayexternal files listFunctioncall this function to execute the JavaScript; accepts a callback function which is called on successChanges are backward-compatible.