fix: handle Notion API's nested response format change#432
Open
amaran-th wants to merge 1 commit intomorethanmin:mainfrom
Open
fix: handle Notion API's nested response format change#432amaran-th wants to merge 1 commit intomorethanmin:mainfrom
amaran-th wants to merge 1 commit intomorethanmin:mainfrom
Conversation
|
Someone is attempting to deploy a commit to the untilled Team on Vercel. A member of the Team first needs to authorize it. |
|
Thanks this solved my problem |
Author
|
@c-jeongyyun const blockEntry = block?.[id]?.value as any
const blockValue = blockEntry?.value ?? blockEntry // ← unwrapped block data
// ...
case "file": {
const Block = blockValue // ← passes unwrapped data with correct `id` and `parent_table`
const newurl = customMapImageUrl(url, Block)
}Could you check if thumbnail images work correctly with this fix applied? If the issue persists, it may be a separate problem worth investigating. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Fixes an issue where the main page shows "Nothing!" with 0 tags due to a change in the Notion API response format.
Problem
The Notion API response structure for
blockandcollectionhas changed:block[id].value→ block data directly ({ type, properties, created_time, ... })block[id].value→{ value: { type, properties, created_time, ... }, role: ... }This causes
rawMetadata.typeingetPosts()to beundefined, failing the type check and returning an empty array[].Solution
Uses
?.value ?? fallbackpattern to support both the old and new response formats.src/apis/notion-client/getPosts.ts: Unwrap nestedcollectionandblockvaluessrc/libs/utils/notion/getPageProperties.ts: Unwrap nested block valueRelated tickets
#425
PR Checklist