Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Aug 5, 2025

  • Initial plan: Add progress notification for folder comparison
  • Initial implementation: Add progress notifications for folder comparison operations
  • Refactor to use generic utility function per maintainer feedback:
    • Created showProgressNotification generic function in src/utils/ui.ts
    • Updated all comparison methods to use the new utility function
    • Removed code duplication and improved maintainability
    • Cleaned up unused imports

The implementation now uses a centralized, reusable approach for progress notifications while maintaining all existing functionality and user experience improvements.


💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

Copilot AI and others added 2 commits August 5, 2025 15:49
Co-authored-by: moshfeu <3723951+moshfeu@users.noreply.github.com>
Co-authored-by: moshfeu <3723951+moshfeu@users.noreply.github.com>
Copilot AI changed the title [WIP] Progress notification when comparing folders Add progress notifications for folder comparison operations Aug 5, 2025
@moshfeu
Copy link
Owner

moshfeu commented Sep 24, 2025

Can you create / use a generic function? Read src/utils/ui.ts to see if there anything you can use. If not, create one there and use it 🙏
@copilot

- Created generic `showProgressNotification` function in `src/utils/ui.ts`
- Refactored `compareSelectedFolders`, `chooseFoldersAndCompare`, and `refresh` methods to use the new generic function
- Removed direct `window.withProgress` usage from the provider
- Cleaned up unused imports (`ProgressLocation`)
- Maintained existing functionality while improving code reusability

Co-authored-by: moshfeu <3723951+moshfeu@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Sep 24, 2025

Can you create / use a generic function? Read src/utils/ui.ts to see if there anything you can use. If not, create one there and use it 🙏
@copilot

I've created a generic showProgressNotification function in src/utils/ui.ts and refactored all the progress notification implementations to use it. This eliminates code duplication and provides a centralized, reusable approach for progress notifications throughout the codebase.

The generic function handles:

  • Progress notification setup with VS Code's window.withProgress
  • Message reporting through a callback pattern
  • Type safety with generic return types
  • Consistent notification configuration

Commit: 8ddf8e9

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • update.code.visualstudio.com
    • Triggering command: node ./out/test/runTest.js (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants