Conversation
|
Warning The base branch is currently set to |
|
View this pull request in Lando to land it once approved. |
| components:feature-summarization-api: | ||
| description: Contracts and configuration for the Summarization (S2S) feature. | ||
| path: components/feature/summarization/api | ||
| publish: false | ||
| upstream_dependencies: | ||
| - components:tooling-lint | ||
| components:feature-summarization: | ||
| description: UI/store layer for the Summarization (S2S) feature. | ||
| path: components/feature/summarization/ui | ||
| publish: false | ||
| upstream_dependencies: | ||
| - components:feature-summarization-api | ||
| - components:tooling-lint | ||
| components:feature-summarization-impl: | ||
| description: Default implementations for the Summarization (S2S) feature. | ||
| path: components/feature/summarization/impl | ||
| publish: false | ||
| upstream_dependencies: | ||
| - components:feature-summarization-api | ||
| - components:tooling-lint | ||
| components:feature-summarization-wiring: | ||
| description: Wiring factory for assembling the Summarization (S2S) feature. | ||
| path: components/feature/summarization/wiring | ||
| publish: false | ||
| upstream_dependencies: | ||
| - components:feature-summarization | ||
| - components:feature-summarization-impl | ||
| - components:feature-summarization-api | ||
| - components:tooling-lint |
There was a problem hiding this comment.
@fmasalha hey, quick drive-by 🚗 : for these API modules, we have categorizations similar to the ones you have here that fit together with our patterns instead of everything being a "feature" module. Have a look at our docs and let me know if you have question: https://mozac.org/contributing/architecture
For example, feature-summarization-api would probably be concept-summarization
There was a problem hiding this comment.
Thank you for the info, this patch was updated to only include the feature flag with the structure being covered in 257d427
segunfamisa
left a comment
segunfamisa
left a comment
There was a problem hiding this comment.
Thanks @fmasalha this looks good to me.
Please don't forget to update the pull request title
4 participants
No description provided.