Bug 2010695 - Add empty modules for S2S feature#41
Bug 2010695 - Add empty modules for S2S feature#41MatthewTighe wants to merge 1 commit intomozilla-firefox:autolandfrom
Conversation
|
View this pull request in Lando to land it once approved. |
segunfamisa
left a comment
segunfamisa
left a comment
There was a problem hiding this comment.
Thank you!
That looks good to me. My only comment is to use this opportunity to start with good enough READMEs so that we don't have to do it retroactively.
I think the same blobs we have in buildconfig.yml is even sufficient. What do you think? I'm approving anyway.
Thank you!
| @@ -0,0 +1,9 @@ | |||
| # [Android Components](../../../README.md) > Concept > LLM | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
I think we have an opportunity to properly document and explain what this module is about. I think we should do that in the readme.
There was a problem hiding this comment.
Yes, this was just intended to be a placeholder for now. I've copied over the descriptions from the buildconfig, but let's flesh this out as we work on the modules themselves.
| @@ -0,0 +1,9 @@ | |||
| # [Android Components](../../../README.md) > Feature > SUMMARIZE | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Same here and other modules
MatthewTighe
force-pushed
the
s2s-empty-modules
branch
from
257d427 to
1d35472
Compare
| publish: true | ||
| upstream_dependencies: | ||
| - components:tooling-lint | ||
| components:lib-llm-gemini-nano: |
There was a problem hiding this comment.
nit naming: the hyphens are like namespaces. So you shouldn't need the last one. You've got the right format otherwise.
For example, lib-fetch has httpurlconnection and okhttp versions.
| components:lib-llm-gemini-nano: | |
| components:lib-llm-gemininano: |
There was a problem hiding this comment.
okay, thanks! is this documented anywhere?
There was a problem hiding this comment.
It's a general package naming strategy. The google style guide has a decent description for it: https://google.github.io/styleguide/javaguide.html#s5.2.1-package-names
MatthewTighe
force-pushed
the
s2s-empty-modules
branch
from
1d35472 to
692617b
Compare
MatthewTighe
force-pushed
the
s2s-empty-modules
branch
from
692617b to
859bef4
Compare
|
Pull request closed by commit 13890fd |
4 participants
No description provided.