Bug 2010700 - Created public compose root and store primitives for s2s#46
Bug 2010700 - Created public compose root and store primitives for s2s#46fmasalha wants to merge 1 commit intomozilla-firefox:autolandfrom
Conversation
|
View this pull request in Lando to land it once approved. |
There was a problem hiding this comment.
Nice, this is looking good. Make sure you run a try - I imagine this will hit failures on linting for some of the undocumented public APIs at least. I don't think we have any real automation setup for Github yet. Other than that, I don't have any blocking feedback. Since we are planning to iterate on we can just make changes as we discover we need them
mobile/android/android-components/components/feature/summarize/build.gradle
Outdated
Show resolved
Hide resolved
...s/feature/summarize/src/main/java/mozilla/components/feature/summarize/SummarizationStore.kt
Outdated
Show resolved
Hide resolved
.../feature/summarize/src/main/java/mozilla/components/feature/summarize/SummarizationScreen.kt
Outdated
Show resolved
Hide resolved
...s/feature/summarize/src/main/java/mozilla/components/feature/summarize/SummarizationState.kt
Outdated
Show resolved
Hide resolved
...s/feature/summarize/src/main/java/mozilla/components/feature/summarize/SummarizationStore.kt
Outdated
Show resolved
Hide resolved
...s/feature/summarize/src/main/java/mozilla/components/feature/summarize/SummarizationState.kt
Outdated
Show resolved
Hide resolved
.../feature/summarize/src/main/java/mozilla/components/feature/summarize/SummarizationScreen.kt
Outdated
Show resolved
Hide resolved
|
Ty for the review, here is the try attempt https://treeherder.mozilla.org/jobs?repo=try&landoCommitID=175715 Ran the linter locally and got no errors after adding a docstring for the public compose function. |
|
hopefully the final updated try: https://treeherder.mozilla.org/jobs?repo=try&revision=4f6862874bbdb8ea13a3de49352b522db8b7a101 |
…s r=matt-tighe Pull request: #46
|
Pull request closed by commit 30f74b2 |
2 participants
No description provided.