Bug 2014529 - Implement summarization permission / consent UI components#55
Open
segunfamisa wants to merge 1 commit intomozilla-firefox:autolandfrom
Open
Bug 2014529 - Implement summarization permission / consent UI components#55segunfamisa wants to merge 1 commit intomozilla-firefox:autolandfrom
segunfamisa wants to merge 1 commit intomozilla-firefox:autolandfrom
Conversation
segunfamisa
commented
Feb 4, 2026
| modifier: Modifier = Modifier, | ||
| dispatchAction: (SummarizationAction) -> Unit = {}, | ||
| ) { | ||
| // TODO - we need to determine when to show: |
Contributor
Author
There was a problem hiding this comment.
Since we are working on very similar parts of it, I tried to leave trail of thoughts as TODOs.
I'm not sure what our practice on this is, so, please let me know if it's not pleasant.
Contributor
There was a problem hiding this comment.
I think this is a great idea! Maybe worth filing a task to double-check we've cleaned them all up? This could be a broad task we let linger in the backlog until we're "done"
segunfamisa
commented
Feb 4, 2026
.../feature/summarize/src/main/java/mozilla/components/feature/summarize/SummarizationScreen.kt
Show resolved
Hide resolved
segunfamisa
commented
Feb 4, 2026
...s/feature/summarize/src/main/java/mozilla/components/feature/summarize/SummarizationStore.kt
Show resolved
Hide resolved
segunfamisa
commented
Feb 4, 2026
...s/feature/summarize/src/main/java/mozilla/components/feature/summarize/SummarizationStore.kt
Show resolved
Hide resolved
Contributor
|
View this pull request in Lando to land it once approved. |
MatthewTighe
approved these changes
Feb 5, 2026
...e/summarize/src/main/java/mozilla/components/feature/summarize/ui/SummarizationPermission.kt
Outdated
Show resolved
Hide resolved
| modifier: Modifier = Modifier, | ||
| dispatchAction: (SummarizationAction) -> Unit = {}, | ||
| ) { | ||
| // TODO - we need to determine when to show: |
Contributor
There was a problem hiding this comment.
I think this is a great idea! Maybe worth filing a task to double-check we've cleaned them all up? This could be a broad task we let linger in the backlog until we're "done"
.../feature/summarize/src/main/java/mozilla/components/feature/summarize/SummarizationAction.kt
Outdated
Show resolved
Hide resolved
...s/feature/summarize/src/main/java/mozilla/components/feature/summarize/SummarizationStore.kt
Outdated
Show resolved
Hide resolved
...d/android-components/components/feature/summarize/src/main/res/values/summarizer-strings.xml
Outdated
Show resolved
Hide resolved
...d/android-components/components/feature/summarize/src/main/res/values/summarizer-strings.xml
Outdated
Show resolved
Hide resolved
segunfamisa
force-pushed
the
sf/s2s-permission-ui
branch
from
5d2d578 to
93d866e
Compare
segunfamisa
force-pushed
the
sf/s2s-permission-ui
branch
from
93d866e to
85a79b7
Compare
Contributor
Author
|
new try after rebase: https://treeherder.mozilla.org/jobs?repo=try&landoCommitID=178076 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=2014529
Try: https://treeherder.mozilla.org/jobs?repo=try&landoCommitID=177629
Figma design
Description
This PR adds the basic screen for summarization permission & consent. It does not include any detailed functionality, and does not include the final copies.
Note:
Previews: