fix(nimbus): Handle features without schemas in new UI#13109
Merged
freshstrangemusic merged 1 commit intomainfrom Jul 29, 2025
Merged
fix(nimbus): Handle features without schemas in new UI#13109freshstrangemusic merged 1 commit intomainfrom
freshstrangemusic merged 1 commit intomainfrom
Conversation
freshstrangemusic
requested review from
jaredlockhart and
yashikakhurana
as code owners
Contributor
yashikakhurana
left a comment
yashikakhurana
left a comment
There was a problem hiding this comment.
Thank you @freshstrangemusic, can you also add a test for this
freshstrangemusic
force-pushed
the
push-tzqskslxpnpz
branch
2 times, most recently
from
9199ac1 to
e8083be
Compare
jaredlockhart
approved these changes
Jul 28, 2025
Collaborator
jaredlockhart
left a comment
jaredlockhart
left a comment
There was a problem hiding this comment.
Okay tested locally, looks good works good thnx @freshstrangemusic 🙏
I filed #13113 as a followup 👍
yashikakhurana
approved these changes
Jul 28, 2025
Contributor
yashikakhurana
left a comment
yashikakhurana
left a comment
There was a problem hiding this comment.
Thank you @freshstrangemusic looking good 💯
freshstrangemusic
force-pushed
the
push-tzqskslxpnpz
branch
2 times, most recently
from
1e48775 to
add1e05
Compare
Because: - some features do not have schemas (e.g., "No Feature iOS" and "No Feature Fenix") this commit: - only serializes the schema to the dataset API if the schema exists; and - guards against schemas not existing in the frontend. Fixes #13076
freshstrangemusic
force-pushed
the
push-tzqskslxpnpz
branch
from
add1e05 to
7b9e218
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because:
this commit:
Fixes #13076