bug(nimbus): only highlight one timeline state at a time#13176
Merged
jaredlockhart merged 1 commit intomainfrom Aug 1, 2025
Merged
bug(nimbus): only highlight one timeline state at a time#13176jaredlockhart merged 1 commit intomainfrom
jaredlockhart merged 1 commit intomainfrom
Conversation
Becuase * An experiment can only be in one state at a time * The timeline should clearly reflect this * We hit a bug where both enrolling and observing were highlighted simultaneously This commit * Changes the definition of is_observation to only be true when an experiment is live and paused fixes #13136
jaredlockhart
requested review from
freshstrangemusic and
yashikakhurana
as code owners
relud
approved these changes
Jul 31, 2025
Contributor
|
@jaredlockhart can we wait to merge this, I am testing it locally as it is related to launch flow |
yashikakhurana
approved these changes
Jul 31, 2025
Contributor
yashikakhurana
left a comment
yashikakhurana
left a comment
There was a problem hiding this comment.
Okay all good, thank you, tested lot of scenarios all worked, thank you @jaredlockhart
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Becuase
This commit
fixes #13136