feat(nimbus): support channels in review serializer#13306
Merged
jaredlockhart merged 1 commit intomainfrom Aug 20, 2025
Merged
Conversation
Becuase * We have added a new field called channels for desktop experiments * We need to support validating against channels for desktop experiments * We need to preserve the existing validation for channel for desktop experiments until we finish switching the ui over This commit * Adds new tests to validate against the channels field for desktop experiments * Preserves existing channel validation logic for desktop experiments fixes #13266
jaredlockhart
requested review from
freshstrangemusic and
yashikakhurana
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Becuase
This commit
fixes #13266