feat(nimbus): Add support for new groups in Firefox Labs#13314
Merged
freshstrangemusic merged 1 commit intomainfrom Aug 20, 2025
Merged
feat(nimbus): Add support for new groups in Firefox Labs#13314freshstrangemusic merged 1 commit intomainfrom
freshstrangemusic merged 1 commit intomainfrom
Conversation
freshstrangemusic
requested review from
jaredlockhart and
yashikakhurana
as code owners
freshstrangemusic
force-pushed
the
push-ynktywxtupml
branch
from
b5cb485 to
daf2d57
Compare
freshstrangemusic
force-pushed
the
push-lvoovysokzyl
branch
from
332f94a to
22b93a1
Compare
freshstrangemusic
force-pushed
the
push-ynktywxtupml
branch
from
daf2d57 to
6320be6
Compare
freshstrangemusic
force-pushed
the
push-lvoovysokzyl
branch
from
22b93a1 to
3e65d05
Compare
...imenter/experiments/tests/api/v5/test_serializers/test_nimbus_ready_for_review_serializer.py
Show resolved
Hide resolved
...imenter/experiments/tests/api/v5/test_serializers/test_nimbus_ready_for_review_serializer.py
Outdated
Show resolved
Hide resolved
freshstrangemusic
force-pushed
the
push-lvoovysokzyl
branch
from
3e65d05 to
7201db7
Compare
jaredlockhart
approved these changes
Aug 20, 2025
Collaborator
jaredlockhart
left a comment
jaredlockhart
left a comment
There was a problem hiding this comment.
Yep looks good thnx @freshstrangemusic 🙏
freshstrangemusic
force-pushed
the
push-lvoovysokzyl
branch
from
7201db7 to
99be98f
Compare
freshstrangemusic
force-pushed
the
push-ynktywxtupml
branch
2 times, most recently
from
e721e34 to
18b3656
Compare
freshstrangemusic
force-pushed
the
push-lvoovysokzyl
branch
from
99be98f to
f540197
Compare
freshstrangemusic
force-pushed
the
push-ynktywxtupml
branch
from
18b3656 to
cea3d42
Compare
freshstrangemusic
force-pushed
the
push-lvoovysokzyl
branch
from
f540197 to
5b891c3
Compare
freshstrangemusic
force-pushed
the
push-ynktywxtupml
branch
from
cea3d42 to
cee8b26
Compare
freshstrangemusic
force-pushed
the
push-lvoovysokzyl
branch
from
5b891c3 to
662ba16
Compare
freshstrangemusic
force-pushed
the
push-ynktywxtupml
branch
from
cee8b26 to
608cb65
Compare
freshstrangemusic
force-pushed
the
push-lvoovysokzyl
branch
from
662ba16 to
d472a7c
Compare
freshstrangemusic
force-pushed
the
push-ynktywxtupml
branch
from
608cb65 to
ea1cc9d
Compare
freshstrangemusic
force-pushed
the
push-lvoovysokzyl
branch
from
d472a7c to
27227ad
Compare
freshstrangemusic
force-pushed
the
push-ynktywxtupml
branch
from
ea1cc9d to
b281dd4
Compare
freshstrangemusic
force-pushed
the
push-lvoovysokzyl
branch
from
27227ad to
89ca3c3
Compare
Because:
- we want to support a new group in Firefox Labs ("Productivity"); and
- this group is only available starting in Firefox 144
this commit:
- adds validation of Firefox Labs groups on a per version basis; and
- adds the new Productivity group requiring Firefox 144+.
Fixes #13303
freshstrangemusic
force-pushed
the
push-lvoovysokzyl
branch
from
89ca3c3 to
368c509
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because:
this commit:
Fixes #13303