feature(nimbus): Add deliveries table to feature health page. by b4handjr · Pull Request #13504 · mozilla/experimenter

b4handjr · 2025-09-15T22:17:41Z

Because

We want to display data about recent deliveries based on a feature/application combo on the feature health page

This commit

Adds a deliveries table to the feature health page

Fixes #13485 #13610

b4handjr · 2025-09-15T22:18:15Z

View with features

b4handjr · 2025-09-15T22:18:59Z

View no features

yashikakhurana · 2025-09-15T22:30:44Z

experimenter/experimenter/nimbus_ui/templates/nimbus_experiments/features.html

+                  {% if experiment.is_rollout %}
+                    <td id="delivery-type-rollout" class="p-2 border-1">Rollout</td>
+                  {% else %}
+                    <td id="delivery-type-experiment" class="p-2 border-1">Experiment</td>
+                  {% endif %}


we have this now and we can re use this

experimenter/experimenter/experimenter/experiments/models.py

Line 1539 in 88faa23

def home_type_choice(self):

yashikakhurana · 2025-09-15T22:35:46Z

experimenter/experimenter/nimbus_ui/templates/nimbus_experiments/features.html

+                  <td id="delivery-channel" class="p-2 border-1">{{ experiment.get_channel_display }}</td>
+                  <td id="delivery-min-version" class="p-2 border-1">{{ experiment.firefox_min_version|parse_version }}</td>
+                  <td id="delivery-population-percent" class="p-2 border-1">{{ experiment.population_percent|floatformat:"-1" }}</td>
+                  <td id="delivery-brief" class="p-2 border-1">{{ experiment.delivery_brief|format_not_set }}</td>


also I see that you are applying the same class p-2 border 1 if we move that class up then we wont need to define for each column

So you just want the row defined with a border?

I believe if you will move to the row that css, this should apply to all

Like this? <tr scope="row" class="p-2 border-1">, this seems to just do the row, but not each column in that row.

I think we can skip the borders, if you will notice the other table, we don't use the borders, I would suggest to refer to home page table to be consistent with the design between the pages

Our plan is to use this table on the landing page as well in the future

yashikakhurana

I think we need to remove borders, it is showing 2 borders now, lets say consistent with the design of tables with the home page. Also noticed 2 bugs
1: Look how it is showing the selected feature, if I select that feature again it is not showing any deliveries

Screen.Recording.2025-09-16.at.9.47.01.AM.mov

2: If you select the different application, deliveries data is not getting changed, it is still showing the old data

Screen.Recording.2025-09-16.at.9.47.22.AM.mov

b4handjr · 2025-09-16T21:33:19Z

How does this look

I also fixed the mix of deliveries that was showing up when you first navigated to the page

yashikakhurana · 2025-09-17T15:05:55Z

@b4handjr It is looking really amazing, some minor suggestions would be like to add the same kind of background where we are choosing application and features too

b4handjr · 2025-09-17T15:40:43Z

Done

yashikakhurana

Thank you @b4handjr it is all coming up together, UI is looking really great, found 2 issues, first if I select the application and feature which have experiments available, it shows in the table, but if I change the application it is not updating the deliveries table, you would need to use htmx-target and such as to achieve that, second thing if we dont have experiments available having a message will help such as No deliveries found

Untitled.mov

yashikakhurana · 2025-09-24T06:40:58Z

experimenter/experimenter/nimbus_ui/forms.py

+        choices = [("", "Nothing Selected")]  # Add a default blank field.
+        choices.extend(


I think you can skip this setting manually Nothing selected option, you can refer to locales, countries and channels etc fields they show nothing selected option by default

yashikakhurana · 2025-09-24T06:41:41Z

experimenter/experimenter/nimbus_ui/templates/nimbus_experiments/features.html

+                {% for experiment in experiments %}
+                  <tr scope="row">
+                    <td id="delivery-name">
+                      <a target="_blank"
+                         href="{% url 'nimbus-ui-detail' slug=experiment.slug %}"
+                         class="text-decoration-none fw-medium">{{ experiment.name }}</a>
+                    </td>
+                    <td id="delivery-published-date">{{ experiment.published_date|format_not_set }}</td>
+                    <td id="delivery-type-{{ experiment.home_type_choice }}">{{ experiment.home_type_choice }}</td>
+                    <td id="delivery-channel">{{ experiment.get_channel_display }}</td>
+                    <td id="delivery-min-version">{{ experiment.firefox_min_version|parse_version }}</td>
+                    <td id="delivery-population-percent">{{ experiment.population_percent|floatformat:"-1" }}</td>
+                    <td id="delivery-brief">{{ experiment.delivery_brief|format_not_set }}</td>
+                  {% endfor %}
+                </tr>


Here can you add a check if no experiment is found matching the desktop and feature configuration to show No deliveries found message

b4handjr · 2025-09-26T18:53:48Z

Added "No Deliveries" text, I added some padding so it stands out more

yashikakhurana

ok

okay tested locally and it seems like we cant set ultil we manually set Nothing selected, @b4handjr can you add back nothing selected option and the bug that I see that because it is already selected and not showing the table accordingly until I select it again https://github.com/user-attachments/assets/49b931cc-be8c-4b28-b72c-86720edd489f
option 1- add nothing selected manually
option 2- dont even select the application, then it will not show the features default selected

yashikakhurana

perfect, thank you @b4handjr

b4handjr requested review from freshstrangemusic, jaredlockhart and yashikakhurana as code owners September 15, 2025 22:17

b4handjr force-pushed the fix-13485 branch from 4ca9719 to 14e508a Compare September 15, 2025 22:20

yashikakhurana reviewed Sep 15, 2025

View reviewed changes

yashikakhurana requested changes Sep 16, 2025

View reviewed changes

b4handjr force-pushed the fix-13485 branch from 14e508a to 75519ec Compare September 16, 2025 21:32

b4handjr force-pushed the fix-13485 branch from 75519ec to e3a61a0 Compare September 16, 2025 22:05

b4handjr force-pushed the fix-13485 branch from e3a61a0 to 6e3cc77 Compare September 17, 2025 15:15

b4handjr requested a review from yashikakhurana September 17, 2025 15:40

yashikakhurana requested changes Sep 24, 2025

View reviewed changes

yashikakhurana requested changes Sep 26, 2025

View reviewed changes

b4handjr requested review from jeddai and mikewilli as code owners September 29, 2025 18:21

b4handjr and others added 6 commits September 29, 2025 13:22

feature(nimbus): Add deliveries table to feature health page.

70cc0d4

Add background color and change font sizing.

2055962

Update to show No Deliveries if there are none.

3f3236b

feat(nimbus): Set both default nothing selected

f2c3192

Update to show No Deliveries if there are none.

6de1508

Updates.

ed3233c

b4handjr force-pushed the fix-13485 branch from faed8ca to ed3233c Compare September 29, 2025 18:22

b4handjr removed request for jeddai and mikewilli September 29, 2025 18:23

yashikakhurana approved these changes Sep 29, 2025

View reviewed changes

b4handjr added this pull request to the merge queue Sep 29, 2025

Merged via the queue into main with commit 3200ab4 Sep 29, 2025
17 checks passed

b4handjr deleted the fix-13485 branch September 29, 2025 20:00

b4handjr mentioned this pull request Sep 29, 2025

Set nothing selected application and update features and table on selection of the application #13610

Closed

		choices = [("", "Nothing Selected")] # Add a default blank field.
		choices.extend(

Conversation

b4handjr commented Sep 15, 2025 • edited by yashikakhurana Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

b4handjr commented Sep 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

b4handjr commented Sep 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yashikakhurana left a comment

Choose a reason for hiding this comment

Uh oh!

b4handjr commented Sep 16, 2025

Uh oh!

yashikakhurana commented Sep 17, 2025

Uh oh!

b4handjr commented Sep 17, 2025

Uh oh!

yashikakhurana left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

b4handjr commented Sep 26, 2025

Uh oh!

yashikakhurana left a comment

Choose a reason for hiding this comment

Uh oh!

yashikakhurana left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

b4handjr commented Sep 15, 2025 •

edited by yashikakhurana

Loading

b4handjr commented Sep 15, 2025 •

edited

Loading

b4handjr commented Sep 15, 2025 •

edited

Loading