feat(nimbus) Use conditionals to determine TOU experience points#13684
Merged
jaredlockhart merged 3 commits intomainfrom Oct 15, 2025
Merged
feat(nimbus) Use conditionals to determine TOU experience points#13684jaredlockhart merged 3 commits intomainfrom
jaredlockhart merged 3 commits intomainfrom
Conversation
lmegviar
requested review from
freshstrangemusic,
jaredlockhart and
yashikakhurana
as code owners
lmegviar
force-pushed
the
remove-regex-tou
branch
2 times, most recently
from
f7bb099 to
5dabe14
Compare
jaredlockhart
requested changes
Oct 14, 2025
Collaborator
jaredlockhart
left a comment
jaredlockhart
left a comment
There was a problem hiding this comment.
I think you should be able to do this like this:
((false && 1 || 0) + (false && 1 || 0)) > 1
lmegviar
force-pushed
the
remove-regex-tou
branch
from
5dabe14 to
c02f1aa
Compare
jaredlockhart
approved these changes
Oct 15, 2025
Collaborator
jaredlockhart
left a comment
jaredlockhart
left a comment
There was a problem hiding this comment.
Eyyyyyyy much nicer 🙏
moibra05
pushed a commit
to moibra05/experimenter
that referenced
this pull request
Oct 22, 2025
…illa#13684) Because - We ran into issues with the previously use regExpMatch filter being evaluated differently for experiment enrollment than by ASRouter's targeting evaluation, leading to enrollment errors. This commit - Removes the previous method of calculating TOU experience points and instead calculates points using conditionals. Fixes #github_issue_number
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
This commit
Fixes #github_issue_number