feat(nimbus): Add QA Runs table to feature health page.#13686
Conversation
b4handjr
requested review from
freshstrangemusic,
jaredlockhart and
yashikakhurana
as code owners
b4handjr
force-pushed
the
exp-5800-table
branch
3 times, most recently
from
20b97d3 to
89f20ac
Compare
|
b4handjr
force-pushed
the
exp-5800-table
branch
from
89f20ac to
27d66eb
Compare
|
@b4handjr pagination is working for the features tables or based on qa table? it seems like you are adding both in the code but only one it working |
No I only added it for the QA Runs table |
yashikakhurana
left a comment
yashikakhurana
left a comment
There was a problem hiding this comment.
On initial load it is not showing the deliveries on select of the features, you will need to select different feature and then select the feature again to see the deliveries, also the qa table entries on click opening up new blank features page @b4handjr confirmed that tooltips, sorting and fixing the page so that it open up deliveries on the same page etc etc will be done in a followup tickets
|
oh also pagination works great 🎉 great job @b4handjr on that |
b4handjr
force-pushed
the
exp-5800-table
branch
from
cebbec3 to
60975de
Compare
b4handjr
force-pushed
the
exp-5800-table
branch
from
60975de to
148d760
Compare
yashikakhurana
left a comment
yashikakhurana
left a comment
There was a problem hiding this comment.
Thank you @b4handjr tested locally working fine on initial load was able to select the features, some minor suggestions like changing the id and update the query results with the recently update time, great job
| </div> | ||
| </form> | ||
| <div class="mt-5 card shadow-sm border-0 px-3 py-4 h-100 rounded-3 bg-primary-subtle"> | ||
| <div id="results" |
There was a problem hiding this comment.
non blocker, but would suggest to give different id than results, its confusing with the results page
There was a problem hiding this comment.
I can sneak this into the delivieres table update
| qs = ( | ||
| qs.filter(feature_configs=feature_id) | ||
| .distinct() | ||
| .order_by(self.request.GET.get("sort", "name")) |
There was a problem hiding this comment.
do you want to sort by name, we can also sort by recently updated
There was a problem hiding this comment.
Hmm okay. I do like it sorted alphabetically though,
There was a problem hiding this comment.
for the users they might be interested in seeing the latest changes like home page, but you can check with Karen
| experiments_with_qa_status = qs.exclude( | ||
| qa_status=NimbusExperiment.QAStatus.NOT_SET.value |
Because - We want to add QA Runs to the feature health page This commit - Adds the QA Runs table which only has experiments that have a QA Status set and ignore "Not Set". - Adds pagination to the QA Runs table Fixes mozilla#13683
2 participants
Because
This commit
Fixes #13683