feat(nimbus): Add pagination to deliveries table on featues page.#13704
feat(nimbus): Add pagination to deliveries table on featues page.#13704
Conversation
b4handjr
requested review from
freshstrangemusic,
jaredlockhart and
yashikakhurana
as code owners
|
| {% if deliveries_page_obj.has_other_pages %} | ||
| {% with current_sort=request.GET.sort %} |
There was a problem hiding this comment.
you are adding some sort code, is sorting also included?
There was a problem hiding this comment.
Nope, will remove for the next PR
yashikakhurana
left a comment
yashikakhurana
left a comment
There was a problem hiding this comment.
Also can you add some tests for the pagination? 🙏
I already have pagination tests.. looks like I didn't have one for the qa runs table, sorry about that. Will add it in. |
b4handjr
force-pushed
the
exp-5800-deliveries-table-1
branch
from
d481207 to
837757d
Compare
yashikakhurana
left a comment
yashikakhurana
left a comment
There was a problem hiding this comment.
Functionality wise it is coming along, one thing noticed that pagination spacing seems incorrect- can you fix that?
Follow up tasks-if you can file a ticket for that- on clicking the experiment it is opening up on new page, open up on the page, second: To change the icon on both the table- you can sync with Karen she helped me too to find the cute suitable foxies
b4handjr
force-pushed
the
exp-5800-deliveries-table-1
branch
from
205c03c to
df3b5aa
Compare
yashikakhurana
left a comment
yashikakhurana
left a comment
There was a problem hiding this comment.
Thank you @b4handjr
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
…zilla#13704) Because - We need to have pagination on the deliveries table on the features page This commit - Adds pagination to the deliveries tabel - Updates an ID used for HTMX Fixes mozilla#13703
2 participants
Because
This commit
Fixes #13703