feat(nimbus): Add Sorting to the QA Runs table on the feature health page. by b4handjr · Pull Request #13742 · mozilla/experimenter

b4handjr · 2025-10-21T18:29:48Z

Because

We need to add sorting to the QA Runs table on the feature health page

This commit

Adds sorting to the QA Runs Table
Adds 2 new model fields to the experiment model to keep track of QA runs and dates.

Fixes #13708

mozcloud-preview-environments · 2025-10-22T15:26:09Z

Preview environment has been deployed.

Preview URL: https://pr13711-experimenter.preview.mozilla.cloud

It may take up to 5 minutes for the environment to become available.
If the link doesn't work immediately, please wait a few moments and try again.

You can monitor deployment status in Argo CD.

mozcloud-preview-environments · 2025-10-22T15:31:07Z

Preview environment has been deployed.

Preview URL: https://pr13711-experimenter.preview.mozilla.cloud

It may take up to 5 minutes for the environment to become available.
If the link doesn't work immediately, please wait a few moments and try again.

You can monitor deployment status in Argo CD.

b4handjr · 2025-10-22T15:44:52Z

This is blocked on #13711

b4handjr · 2025-10-22T21:01:51Z

Date sorting:

Type sorting:

mozcloud-preview-environments · 2025-10-22T21:36:14Z

Preview environment has been deployed.

Preview URL: https://pr13742-experimenter.preview.mozilla.cloud

It may take up to 5 minutes for the environment to become available.
If the link doesn't work immediately, please wait a few moments and try again.

You can monitor deployment status in Argo CD.

mozcloud-preview-environments · 2025-10-22T21:41:12Z

Preview environment has been deployed.

Preview URL: https://pr13742-experimenter.preview.mozilla.cloud

It may take up to 5 minutes for the environment to become available.
If the link doesn't work immediately, please wait a few moments and try again.

You can monitor deployment status in Argo CD.

yashikakhurana

In general looking good noticed two things, one on click of the links test plan and test rail results opening up empty page again on new window, I thought we fixed that earlier

Also both the tables are missing tooltips, if you can add them or file ticket for that. Another things on QA table deliveries open up on the same page as they should but feature table still opens up it on the new tab. Sorting working 💯

b4handjr · 2025-10-22T22:40:28Z

In general looking good noticed two things, one on click of the links test plan and test rail results opening up empty page again on new window, I thought we fixed that earlier.

You want the test rail/testplan links to open in the current page? I dont really like that flow, as what if someone wants to open multiple test plans for 1 feature?

Also both the tables are missing tooltips, if you can add them or file ticket for that. Another things on QA table deliveries open up on the same page as they should but feature table still opens up it on the new tab. Sorting working 💯

Yes the tooltips are filed in another ticket, ill get to that this week since it's a small change. And yes about the open in new page, I can fix that with the tooltip since ill be working on that table.

freshstrangemusic · 2025-10-23T14:51:53Z

experimenter/experimenter/experiments/migrations/0295_nimbusexperiment_qa_run_date_and_more.py

@@ -0,0 +1,33 @@
+# Generated by Django 5.2.7 on 2025-10-22 19:44


I think you need to run ruff format on this?

I ran make format and I don't see any errors on CI 🤷🏾

freshstrangemusic · 2025-10-23T14:53:15Z

experimenter/experimenter/static/assets/qa-runs.svg

experimenter/experimenter/experiments/tests/test_models.py

freshstrangemusic · 2025-10-23T14:56:58Z

experimenter/experimenter/experiments/models.py

        default=list,
    )
    tags = models.ManyToManyField(Tag, blank=True, related_name="experiments")
+    qa_run_date = models.DateField("QA Run Date", blank=True, null=True, default=None)


I don't think we want both blank and null as valid values for these fields. I believe Django forms work better with blank=true and a default value of "" instead of trying to make null the "empty" value.

This is how other fields are done currently.. should I change it now and file something to update the rest?

yashikakhurana · 2025-10-23T15:48:48Z

In general looking good noticed two things, one on click of the links test plan and test rail results opening up empty page again on new window, I thought we fixed that earlier.

You want the test rail/testplan links to open in the current page? I dont really like that flow, as what if someone wants to open multiple test plans for 1 feature?

Also both the tables are missing tooltips, if you can add them or file ticket for that. Another things on QA table deliveries open up on the same page as they should but feature table still opens up it on the new tab. Sorting working 💯

Yes the tooltips are filed in another ticket, ill get to that this week since it's a small change. And yes about the open in new page, I can fix that with the tooltip since ill be working on that table.

agree to open up in new tab that's a valid point, but links are not working right now, and if somebody clicks it is opening up the empty feature page, can you fix that?

yashikakhurana · 2025-10-23T15:50:33Z

experimenter/experimenter/experiments/tests/test_models.py

+            [NimbusExperiment.QATestType.FULL, "Full"],
+            [NimbusExperiment.QATestType.SMOKE, "Smoke"],
+            [NimbusExperiment.QATestType.SELF, "Self"],
+            [NimbusExperiment.QATestType.REGRESSION, "Regression"],
+        ]


for the text like Full etc etc you can .value QATestType(models.TextChoices):

Beth gave me a suggestion I implemented

experimenter/experimenter/nimbus_ui/templates/nimbus_experiments/features.html

mozcloud-preview-environments · 2025-10-23T17:15:41Z

Preview environment has been deployed.

Preview URL: https://pr13742-experimenter.preview.mozilla.cloud

It may take up to 5 minutes for the environment to become available.
If the link doesn't work immediately, please wait a few moments and try again.

You can monitor deployment status in Argo CD.

mozcloud-preview-environments · 2025-10-23T17:21:10Z

Preview environment has been deployed.

Preview URL: https://pr13742-experimenter.preview.mozilla.cloud

It may take up to 5 minutes for the environment to become available.
If the link doesn't work immediately, please wait a few moments and try again.

You can monitor deployment status in Argo CD.

yashikakhurana · 2025-10-23T17:41:02Z

@b4handjr can you file a ticket to update the deliveries table too like you did for QA when no deliveries are available-same styling

yashikakhurana · 2025-10-23T17:44:57Z

experimenter/experimenter/nimbus_ui/templates/nimbus_experiments/features.html

+                    </td>
+                    <td id="qa-test-plan">
+                      <a href="{{ experiment.qa_run_test_plan }}">Test Plan Link</a>
+                    </td>
+                    <td id="qa-testrail-link" class="col-2">
+                      <a href="{{ experiment.qa_run_testrail_link }}">TestRail Link</a>
+                    </td>
+                  {% empty %}
+                    <tr>
+                      <td colspan="11" class="text-center text-muted py-5">No QA runs</td>


clicking on those still opening empty features page https://pr13742-experimenter.preview.mozilla.cloud/nimbus/features/None

Oh you want me to remove the actual link, okay sorry, misunderstood

not remove the link, it should be like if we dont have a link it should say not set something like that, or it should be only highlighted if we have links available, like how on all deliveries page if results links are not available we say n/a and if available we show the link

mozcloud-preview-environments · 2025-10-23T18:27:57Z

Preview environment has been deployed.

Preview URL: https://pr13742-experimenter.preview.mozilla.cloud

It may take up to 5 minutes for the environment to become available.
If the link doesn't work immediately, please wait a few moments and try again.

You can monitor deployment status in Argo CD.

mozcloud-preview-environments · 2025-10-23T18:33:05Z

Preview environment has been deployed.

Preview URL: https://pr13742-experimenter.preview.mozilla.cloud

It may take up to 5 minutes for the environment to become available.
If the link doesn't work immediately, please wait a few moments and try again.

You can monitor deployment status in Argo CD.

…page.

b4handjr · 2025-10-23T19:17:00Z

I had to run makemigrations again due to a PR that had the same number for their migration file.

yashikakhurana

Tested everything locally, working fine thanks @b4handjr for some reason preview mode is not working so it took extra time to review and do the set up

b4handjr force-pushed the exp-5800-qa-sorting branch 3 times, most recently from ad491a6 to 1522506 Compare October 21, 2025 22:24

b4handjr mentioned this pull request Oct 22, 2025

feat(nimbus): Add basic feature tracking table to feature health page. #13749

Merged

b4handjr added the Blocked label Oct 22, 2025

b4handjr force-pushed the exp-5800-qa-sorting branch 4 times, most recently from 5ad75b0 to 14d8383 Compare October 22, 2025 20:40

b4handjr removed the Blocked label Oct 22, 2025

b4handjr marked this pull request as ready for review October 22, 2025 21:02

b4handjr requested review from freshstrangemusic, jaredlockhart and yashikakhurana as code owners October 22, 2025 21:02

yashikakhurana added the preview Create Preview Environment label Oct 22, 2025

yashikakhurana requested changes Oct 22, 2025

View reviewed changes

b4handjr requested a review from yashikakhurana October 23, 2025 13:54

freshstrangemusic reviewed Oct 23, 2025

View reviewed changes

yashikakhurana reviewed Oct 23, 2025

View reviewed changes

b4handjr requested review from freshstrangemusic and yashikakhurana October 23, 2025 17:11

yashikakhurana requested changes Oct 23, 2025

View reviewed changes

b4handjr force-pushed the exp-5800-qa-sorting branch 2 times, most recently from 4ca3e06 to 48e89fb Compare October 23, 2025 18:18

b4handjr added 2 commits October 23, 2025 13:50

feat(nimbus): Add Sorting to the QA Runs table on the feature health …

6e838db

…page.

Updates based on review.

c4822ef

b4handjr force-pushed the exp-5800-qa-sorting branch from 48e89fb to c4822ef Compare October 23, 2025 19:14

b4handjr requested a review from yashikakhurana October 23, 2025 19:35

b4handjr enabled auto-merge October 23, 2025 22:14

yashikakhurana added preview Create Preview Environment and removed preview Create Preview Environment labels Oct 24, 2025

Merge branch 'main' into exp-5800-qa-sorting

bd9bc69

yashikakhurana approved these changes Oct 24, 2025

View reviewed changes

b4handjr added this pull request to the merge queue Oct 24, 2025

Merged via the queue into main with commit 2cb567d Oct 24, 2025
17 of 18 checks passed

b4handjr deleted the exp-5800-qa-sorting branch October 24, 2025 16:10

		@@ -0,0 +1,33 @@
		# Generated by Django 5.2.7 on 2025-10-22 19:44

Comments

Conversation

b4handjr commented Oct 21, 2025

Uh oh!

mozcloud-preview-environments bot commented Oct 22, 2025

Uh oh!

mozcloud-preview-environments bot commented Oct 22, 2025

Uh oh!

b4handjr commented Oct 22, 2025

Uh oh!

b4handjr commented Oct 22, 2025

Uh oh!

mozcloud-preview-environments bot commented Oct 22, 2025

Uh oh!

mozcloud-preview-environments bot commented Oct 22, 2025

Uh oh!

yashikakhurana left a comment

Choose a reason for hiding this comment

Uh oh!

b4handjr commented Oct 22, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yashikakhurana commented Oct 23, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

mozcloud-preview-environments bot commented Oct 23, 2025

Uh oh!

mozcloud-preview-environments bot commented Oct 23, 2025

Uh oh!

yashikakhurana commented Oct 23, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mozcloud-preview-environments bot commented Oct 23, 2025

Uh oh!

mozcloud-preview-environments bot commented Oct 23, 2025

Uh oh!

b4handjr commented Oct 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yashikakhurana left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

b4handjr commented Oct 23, 2025 •

edited

Loading