feat(nimbus): exclude language/locale/country#13753
Conversation
Becuase * We need a way to optionally exclude selected languages/locales/countries This commit * Adds a bool flag to exclude languages/locales/countries * Negates the JEXL expressions for each if exclude is selected * Adds checkboxes for each on the audience page * Updates the summary page to show whether each is included or excluded fixes #13752
jaredlockhart
requested review from
freshstrangemusic and
yashikakhurana
as code owners
|
|
Preview environment has been deployed. Preview URL: https://pr13753-experimenter.preview.mozilla.cloud It may take up to 5 minutes for the environment to become available. You can monitor deployment status in Argo CD. |
1 similar comment
|
Preview environment has been deployed. Preview URL: https://pr13753-experimenter.preview.mozilla.cloud It may take up to 5 minutes for the environment to become available. You can monitor deployment status in Argo CD. |
yashikakhurana
left a comment
yashikakhurana
left a comment
There was a problem hiding this comment.
Tested locally works pefectly fine, interesting to see the approach, thanks @jaredlockhart
|
Preview environment has been deployed. Preview URL: https://pr13753-experimenter.preview.mozilla.cloud It may take up to 5 minutes for the environment to become available. You can monitor deployment status in Argo CD. |
1 similar comment
|
Preview environment has been deployed. Preview URL: https://pr13753-experimenter.preview.mozilla.cloud It may take up to 5 minutes for the environment to become available. You can monitor deployment status in Argo CD. |
3 participants
Becuase
This commit
fixes #13752