-
Notifications
You must be signed in to change notification settings - Fork 220
feat(nimbus): create new results page overview section #13777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
b27e3da
feat(nimbus): setup results page with required data
moibra05 d364476
feat(nimbus): setup results page with required data
moibra05 96b4e56
chore(nimbus): Update External Configs (#13701)
experimenter-github-app[bot] f8d73f1
feat(nimbus): create new results page overview section
moibra05 75328af
Merge branch 'main' into 13734
moibra05 438dac4
Merge branch 'main' into 13734
moibra05 2bfe53f
Merge branch 'main' into 13734
moibra05 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
30 changes: 30 additions & 0 deletions
30
experimenter/experimenter/nimbus_ui/templates/common/branch_card.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| {% load nimbus_extras %} | ||
|
|
||
| <div class="d-flex gap-4"> | ||
| {% with shot=branch.screenshots.first %} | ||
| {% if shot and shot.image %} | ||
| <img src="{{ shot.image.url }}" | ||
| alt="{{ shot.description|default:branch.name }}" | ||
| class="border border-secondary-subtle rounded w-50" | ||
| style="height: 120px; | ||
| object-fit: cover" /> | ||
| {% else %} | ||
| <div class="border border-secondary-subtle rounded text-center d-flex align-items-center justify-content-center w-50" | ||
| style="height: 120px"> | ||
| <small class="text-muted">No screenshot</small> | ||
| </div> | ||
| {% endif %} | ||
| {% endwith %} | ||
| <div class="w-50"> | ||
| <span class="badge rounded-pill text-body-secondary bg-body-secondary border border-secondary-subtle d-flex-inline d-inline-flex flex-wrap gap-2"> | ||
| {{ branch.name }} | ||
| <div class="d-inline-flex gap-1 fw-normal"> | ||
| {{ branch.percentage|floatformat:"0g" }}% | ||
| <span>·</span> | ||
| {{ branch.num_participants|short_number }} users | ||
| </div> | ||
| </span> | ||
| <h6 class="mt-2">{{ branch.name }}</h6> | ||
| <p class="text-muted">{{ branch.description|truncatechars:100 }}</p> | ||
| </div> | ||
| </div> | ||
118 changes: 118 additions & 0 deletions
118
experimenter/experimenter/nimbus_ui/templates/nimbus_experiments/results-new.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,118 @@ | ||
| {% extends "nimbus_experiments/experiment_base.html" %} | ||
|
|
||
| {% load static %} | ||
| {% load nimbus_extras %} | ||
|
|
||
| {% block title %}{{ experiment.name }}{% endblock %} | ||
|
|
||
| {% block main_content %} | ||
| <div class="card px-5 py-4 shadow-sm"> | ||
| <h3>Overview</h3> | ||
| <div class="d-inline-flex gap-4"> | ||
| {% for section in overview_sections %} | ||
| <p class="text-muted">{{ section }}</p> | ||
| {% if not forloop.last %}<span class="text-muted">·</span>{% endif %} | ||
| {% endfor %} | ||
| </div> | ||
| <div class="d-flex flex-column gap-4"> | ||
| <div class="card p-5 mt-4"> | ||
| <div class="row"> | ||
| <div class="col-xxl"> | ||
| <h5>Hypothesis</h5> | ||
| {% with hyp=experiment.hypothesis|default:"No hypothesis set." %} | ||
| {% if hyp|length > 300 %} | ||
| <p> | ||
| {{ hyp|truncatechars:300 }} | ||
| <a href="{{ experiment.get_detail_url }}" class="ms-1">More</a> | ||
| </p> | ||
| {% else %} | ||
| <p>{{ hyp }}</p> | ||
| {% endif %} | ||
| {% endwith %} | ||
| </div> | ||
| <div class="col-xxl"> | ||
| <div class="row"> | ||
| <div class="col"> | ||
| <p class="text-muted mb-0">Product Owner</p> | ||
| <p>{{ experiment.owner|default:"No product owner set." }}</p> | ||
| </div> | ||
| <div class="col"> | ||
| <p class="text-muted mb-0">Advanced Targeting</p> | ||
| <p>{{ experiment.targeting_config.name }}</p> | ||
| </div> | ||
| <div class="col"> | ||
| <p class="text-muted mb-0">Application</p> | ||
| <p>{{ experiment.application|default:"Unknown" }}</p> | ||
| </div> | ||
| </div> | ||
| <div class="row"> | ||
| <div class="col"> | ||
| <p class="text-muted mb-0">Feature tags</p> | ||
| {% for tag in experiment.tags.all %} | ||
| <span class="badge bg-light text-dark">{{ tag.name }}</span> | ||
| {% empty %} | ||
| <p>None</p> | ||
| {% endfor %} | ||
| </div> | ||
| <div class="col"> | ||
| <p class="text-muted mb-0">Localization</p> | ||
| {% for locale in experiment.locales.all %} | ||
| <p class="mb-0">{{ locale.name }}</p> | ||
| {% empty %} | ||
| <p class="mb-0">None</p> | ||
| {% endfor %} | ||
| </div> | ||
| <div class="col"> | ||
| <p class="text-muted mb-0">Version</p> | ||
| <p> | ||
| {{ experiment.firefox_min_version }} | ||
| {% if experiment.firefox_max_version %} | ||
| - {{ experiment.firefox_max_version }} | ||
| {% else %} | ||
| + | ||
| {% endif %} | ||
| </p> | ||
| </div> | ||
| </div> | ||
| </div> | ||
| </div> | ||
| </div> | ||
| <div class="card p-5"> | ||
| <div class="row row-cols-2 row-cols-xxl-3 g-4"> | ||
| {% for branch in branch_data %} | ||
| <div class="col"> | ||
| {% include "common/branch_card.html" with branch=branch %} | ||
|
|
||
| </div> | ||
| {% endfor %} | ||
| </div> | ||
| </div> | ||
| <div class="card p-5"> | ||
| <div class="row"> | ||
| <div class="col"> | ||
| <h5>Key takeaways</h5> | ||
| <p class="text-muted"> | ||
| {{ experiment.key_takeaways|default:"Highlight the most important learnings or patterns from this experiment." }} | ||
| </p> | ||
| </div> | ||
| <div class="col"> | ||
| <h5>Next steps</h5> | ||
| <p class="text-muted"> | ||
| {{ experiment.key_takeaways|default:"Outline what should happen next based on these results — fixes, follow-ups, or future tests." }} | ||
| </p> | ||
| </div> | ||
| <div class="col"> | ||
| <div class="d-flex align-items-start gap-2"> | ||
| {% comment %} TODO: {% endcomment %} | ||
| <h5>Project Impact</h5> | ||
| <span class="badge rounded-pill text-bg-warning bg-opacity-25 border border-secondary-subtle">Incomplete</span> | ||
| </div> | ||
| <p class="text-muted"> | ||
| {{ experiment.key_takeaways|default:"Set an impact rating so others can understand the scale of this experiment’s effect." }} | ||
| </p> | ||
| </div> | ||
| </div> | ||
| </div> | ||
| </div> | ||
| </div> | ||
| {% endblock main_content %} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.