Skip to content

Comments

feat(nimbus): Add subscribers field to feature config model.#13787

Merged
b4handjr merged 2 commits intomainfrom
fix-13783
Oct 28, 2025
Merged

feat(nimbus): Add subscribers field to feature config model.#13787
b4handjr merged 2 commits intomainfrom
fix-13783

Conversation

@b4handjr
Copy link
Contributor

Because

  • We want to allow a user to subscribe to a feature and get notifications when that feature is used

This commit

  • Adds the subscribers field to the Feature Config class.

Fixes #13783

@b4handjr b4handjr changed the title feat(nimbus): Add subscribers feature to feature config model. feat(nimbus): Add subscribers field to feature config model. Oct 27, 2025
Copy link
Contributor

@yashikakhurana yashikakhurana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahaa I see adding a subscriber for that, just a suggestion the name subscriber is little bit confusing for me, as we have subscriber for the experiments too, seeing the same field might be little confusing 🤔

@freshstrangemusic
Copy link
Member

ahaa I see adding a subscriber for that, just a suggestion the name subscriber is little bit confusing for me, as we have subscriber for the experiments too, seeing the same field might be little confusing 🤔

Its the same name on two different models. And the concept is the same -- a subscription.

We have types, I don't see this being a problem.

@@ -0,0 +1,20 @@
# Generated by Django 5.2.7 on 2025-10-27 15:00
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a ruff format.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We must have a bug on our make lint step as it sometimes doesn't report these.

@b4handjr b4handjr enabled auto-merge October 28, 2025 16:12
@b4handjr b4handjr force-pushed the fix-13783 branch 2 times, most recently from 7e9e33e to 022334d Compare October 28, 2025 16:25
Copy link
Contributor

@yashikakhurana yashikakhurana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah I understand the concept is same, I said it is confusing for me :D, lets :shipit:

@b4handjr b4handjr added this pull request to the merge queue Oct 28, 2025
Merged via the queue into main with commit a098567 Oct 28, 2025
17 checks passed
@b4handjr b4handjr deleted the fix-13783 branch October 28, 2025 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add subscribers field to FeatureConfig

3 participants