Skip to content

Comments

bug(experimenter): give glean a unique data dir per pid#13789

Merged
relud merged 1 commit intomainfrom
relud-glean-data-dir-pid
Oct 27, 2025
Merged

bug(experimenter): give glean a unique data dir per pid#13789
relud merged 1 commit intomainfrom
relud-glean-data-dir-pid

Conversation

@relud
Copy link
Contributor

@relud relud commented Oct 27, 2025

Because

  • glean must have a unique data dir per pid

This commit

  • Adds a process id subdir to the glean data dir path

Fixes #13788

GLEAN_UPLOAD_ENABLED = config("GLEAN_UPLOAD_ENABLED", default=False, cast=bool)

GLEAN_DATA_DIR = config("GLEAN_DATA_DIR", default="/var/glean")
GLEAN_DATA_DIR = Path(config("GLEAN_DATA_DIR", default="/var/glean")) / str(os.getpid())
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this matches what was done for the same issue in cirrus:

data_dir: Path = Path("/var/glean") / str(os.getpid())

Copy link
Contributor

@yashikakhurana yashikakhurana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @relud :shipit:

@relud relud added this pull request to the merge queue Oct 27, 2025
Merged via the queue into main with commit ab01506 Oct 27, 2025
16 checks passed
@relud relud deleted the relud-glean-data-dir-pid branch October 27, 2025 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Glean requires a different data dir per pid

2 participants