feat(nimbus) - Add targeting for TOU accepted before Dec 9, 2025

[lmegviar]

Because

• We need to show a message to users who accepted the TOU before Dec 9, 2025 alerting them to a privacy notice update.

This commit

• Add this new targeting and comment explaining the way we'll determine accepted variant of TOU moving forward.

Fixes #13804

[lmegviar]

Nov 12 date isn't final, so updated patch with TODOs until that's solidified.

[lmegviar]

We only want to exclude Linux in the "before dec 9" targeting and not in the "on or after dec 9" targeting.

[lmegviar]

Thanks, @freshstrangemusic - updated.

[jaredlockhart]

LGTM 👍

Stray comma removed

[jaredlockhart]

@lmegviar Ah looks like some JEXL validation errors:

self = <Sequence expression = _ (conditional_expression / binary_expression / unary_expression / complex_value) _>
text = "\n    (\n        !os.isLinux\n        &&\n        ('termsofuse.acceptedDate'|preferenceValue != '0')\n        &&\n        ((('termsofuse.acceptedDate'|preferenceValue * 1) | date) < 1765324740000|date)\n    )\n    "
pos = 0

    def match(self, text, pos=0):
        """Return the parse tree matching this expression at the given
        position, not necessarily extending all the way to the end of ``text``.
    
        Raise ``ParseError`` if there is no match there.
    
        :arg pos: The index at which to start matching
    
        """
        error = ParseError(text)
        node = self.match_core(text, pos, defaultdict(dict), error)
        if node is None:
>           raise error
E           parsimonious.exceptions.ParseError: Rule 'binary_operator' didn't match at '| date) < 1765324740' (line 7, column 59).

/usr/local/lib/python3.13/site-packages/parsimonious/expressions.py:158: ParseError

--------

self = <experimenter.targeting.tests.test_targeting_configs.TestTargetingConfigs testMethod=test_targeting_config_has_valid_jexl_227>
targeting_config = NimbusTargetingConfig(name='Accepted TOU on or after Dec 9, 2025', slug='accepted_tou_on_or_after_dec_9_2025', description='User accepted TOU on or after Dec 9, 2025', targeting="\n    (\n        ('termsofuse.acceptedDate'|preferenceValue != '0')\n        &&\n        ((('termsofuse.acceptedDate'|preferenceValue * 1) | date) >= 1765324740000|date)\n    )\n    ", desktop_telemetry='', sticky_required=False, is_first_run_required=False, application_choice_names=('DESKTOP',))

    @parameterized.expand([(t,) for t in TargetingConstants.TARGETING_CONFIGS.values()])
    def test_targeting_config_has_valid_jexl(self, targeting_config):
        if targeting_config.targeting:
            try:
                JEXLParser().parse(targeting_config.targeting)
            except ParseError as e:
>               raise Exception(
                    f"JEXL Parse error in {targeting_config.name}: {e}"
                ) from e
E               Exception: JEXL Parse error in Accepted TOU on or after Dec 9, 2025: Rule 'binary_operator' didn't match at '| date) >= 176532474' (line 5, column 59).

experimenter/targeting/tests/test_targeting_configs.py:24: Exception

[lmegviar]

@lmegviar Ah looks like some JEXL validation errors:

Thanks @jaredlockhart - I think they're addressed, I still see two CircleCI failures but they seem unrelated (I think you mentioned there are a couple that can be flaky and I don't have permission to get them to rerun).