feat(nimbus): display feature coenrollment#13854
Merged
yashikakhurana merged 2 commits intomainfrom Nov 5, 2025
Merged
Conversation
jaredlockhart
requested review from
freshstrangemusic and
yashikakhurana
as code owners
Collaborator
Author
|
Collaborator
Author
|
Blocked on #13853 |
...imenter/experimenter/experiments/migrations/0298_nimbusversionedschema_allow_coenrollment.py
Outdated
Show resolved
Hide resolved
yashikakhurana
requested changes
Nov 3, 2025
Contributor
yashikakhurana
left a comment
yashikakhurana
left a comment
There was a problem hiding this comment.
Thank you @jaredlockhart overall looks good, one suggestion to move the messages into a constant file
experimenter/experimenter/nimbus_ui/templates/nimbus_experiments/detail_branch.html
Outdated
Show resolved
Hide resolved
experimenter/experimenter/nimbus_ui/templates/nimbus_experiments/edit_branches.html
Outdated
Show resolved
Hide resolved
jaredlockhart
force-pushed
the
12914a
branch
2 times, most recently
from
1516ac0 to
4f7bc21
Compare
yashikakhurana
approved these changes
Nov 3, 2025
Contributor
yashikakhurana
left a comment
yashikakhurana
left a comment
There was a problem hiding this comment.
perfect thanks @jaredlockhart
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
freshstrangemusic
requested changes
Nov 4, 2025
experimenter/experimenter/features/management/commands/load_feature_configs.py
Show resolved
Hide resolved
experimenter/experimenter/features/management/commands/load_feature_configs.py
Show resolved
Hide resolved
Becuase * We now support coenrolling features in all Nimbus clients * It would be handy to know if a feature is coenrolling in the UI This commit * Adds a new field to store allow_coenrollment on features * Displays a message on the branch page if a feature supports coenrollment * Displays a message on the summary page if a feature supports coenrollment fixes #12914
yashikakhurana
approved these changes
Nov 4, 2025
Contributor
yashikakhurana
left a comment
yashikakhurana
left a comment
There was a problem hiding this comment.
Looks good to me! Thanks @jaredlockhart
freshstrangemusic
approved these changes
Nov 5, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 5, 2025
Because
* We now support coenrolling features in all Nimbus clients
* It would be handy to know if a feature is coenrolling in the UI
This commit
* Adds a new field to store allow_coenrollment on features
* Displays a message on the branch page if a feature supports
coenrollment
* Displays a message on the summary page if a feature supports
coenrollment
fixes #12914
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
This commit
fixes #12914