feat(nimbus): create filters for updated results page by moibra05 · Pull Request #13870 · mozilla/experimenter

moibra05 · 2025-11-03T19:30:06Z

Because

Users need a way to change the analysis basis, reference branch, and segment view for result data

This commit

Creates drop down filters for each of the above listed fields
Analysis basis drop down only shows exposures if the experiment has them

Fixes #13720

moibra05 · 2025-11-03T19:30:21Z

mozcloud-preview-environments · 2025-11-03T19:51:41Z

Preview environment has been deployed.

Preview URL: https://pr13870-experimenter.preview.mozilla.cloud

It may take up to 5 minutes for the environment to become available.
If the link doesn't work immediately, please wait a few moments and try again.

You can monitor deployment status in Argo CD.

mozcloud-preview-environments · 2025-11-03T19:56:34Z

Preview environment has been deployed.

Preview URL: https://pr13870-experimenter.preview.mozilla.cloud

It may take up to 5 minutes for the environment to become available.
If the link doesn't work immediately, please wait a few moments and try again.

You can monitor deployment status in Argo CD.

mozcloud-preview-environments · 2025-11-03T21:18:56Z

Preview environment has been deployed.

Preview URL: https://pr13870-experimenter.preview.mozilla.cloud

It may take up to 5 minutes for the environment to become available.
If the link doesn't work immediately, please wait a few moments and try again.

You can monitor deployment status in Argo CD.

mozcloud-preview-environments · 2025-11-03T21:23:46Z

Preview environment has been deployed.

Preview URL: https://pr13870-experimenter.preview.mozilla.cloud

It may take up to 5 minutes for the environment to become available.
If the link doesn't work immediately, please wait a few moments and try again.

You can monitor deployment status in Argo CD.

yashikakhurana

Thanks @moibra05 in general looks good, I have one suggestion if you can try to target specifics id instead of body

experimenter/experimenter/nimbus_ui/templates/nimbus_experiments/results-new.html

mozcloud-preview-environments · 2025-11-04T17:50:00Z

Preview environment has been deployed.

Preview URL: https://pr13870-experimenter.preview.mozilla.cloud

It may take up to 5 minutes for the environment to become available.
If the link doesn't work immediately, please wait a few moments and try again.

You can monitor deployment status in Argo CD.

mozcloud-preview-environments · 2025-11-04T17:55:35Z

Preview environment has been deployed.

Preview URL: https://pr13870-experimenter.preview.mozilla.cloud

It may take up to 5 minutes for the environment to become available.
If the link doesn't work immediately, please wait a few moments and try again.

You can monitor deployment status in Argo CD.

yashikakhurana

@moibra05 I know you are adding the placeholders for filters, but can you confirm these filters work I am trying on this one- https://pr13870-experimenter.preview.mozilla.cloud/nimbus/ctataru/results-new/?analysis_basis=exposures&reference_branch=treatment-a&segment=all

yashikakhurana · 2025-11-04T23:11:32Z

experimenter/experimenter/nimbus_ui/templates/nimbus_experiments/results-new.html

-            {% for branch in branch_data %}
-              <div class="col">
-                {% include "common/branch_card.html" with branch=branch %}
+  {% include "nimbus_experiments/results-new-fragment.html" %}


I believe this file results-new.html is only containing results-new-fragment right? if that is the case I dont think we need separate file for this?

results-new.html also extends nimbus_experiments/experiment_base.html which contains other experimenter page elements such as the header and sidebar. when i make htmx get requests back to the new results page to reload content on filter changes i only want the results page content to be returned which is what results-new-fragment contains. separating these files gives me control in the exact content returned by the view depending on if the HX-Request header is provided

also yes, filters should work and appear to be with the experiment you linked

mozcloud-preview-environments · 2025-11-05T15:54:15Z

Preview environment has been deployed.

Preview URL: https://pr13870-experimenter.preview.mozilla.cloud

It may take up to 5 minutes for the environment to become available.
If the link doesn't work immediately, please wait a few moments and try again.

You can monitor deployment status in Argo CD.

mozcloud-preview-environments · 2025-11-05T15:59:39Z

Preview environment has been deployed.

Preview URL: https://pr13870-experimenter.preview.mozilla.cloud

It may take up to 5 minutes for the environment to become available.
If the link doesn't work immediately, please wait a few moments and try again.

You can monitor deployment status in Argo CD.

mozcloud-preview-environments · 2025-11-05T19:59:49Z

Preview environment has been deployed.

Preview URL: https://pr13870-experimenter.preview.mozilla.cloud

It may take up to 5 minutes for the environment to become available.
If the link doesn't work immediately, please wait a few moments and try again.

You can monitor deployment status in Argo CD.

yashikakhurana

Thank you @moibra05 I tried the filtering it is working 🎉 just having multiple cards if we can loop somehow to improve it, also one suggestion unrelated to this PR the spacing looks little bit off here, whenver you have a chance to fix it

yashikakhurana · 2025-11-05T19:59:56Z

experimenter/experimenter/nimbus_ui/templates/nimbus_experiments/results-new-inner.html

+            <div class="d-flex flex-column gap-3 w-100">
+              {% include "common/metric_card.html" with slug=branch.slug reference_branch=selected_reference_branch %}
+              {% include "common/metric_card.html" with slug=branch.slug reference_branch=selected_reference_branch %}
+              {% include "common/metric_card.html" with slug=branch.slug reference_branch=selected_reference_branch %}
+              {% include "common/metric_card.html" with slug=branch.slug reference_branch=selected_reference_branch %}
+              {% include "common/metric_card.html" with slug=branch.slug reference_branch=selected_reference_branch %}
+              {% include "common/metric_card.html" with slug=branch.slug reference_branch=selected_reference_branch %}
+              {% include "common/metric_card.html" with slug=branch.slug reference_branch=selected_reference_branch %}
+              {% include "common/metric_card.html" with slug=branch.slug reference_branch=selected_reference_branch %}
+              {% include "common/metric_card.html" with slug=branch.slug reference_branch=selected_reference_branch %}
+              {% include "common/metric_card.html" with slug=branch.slug reference_branch=selected_reference_branch %}
+              {% include "common/metric_card.html" with slug=branch.slug reference_branch=selected_reference_branch %}
+              {% include "common/metric_card.html" with slug=branch.slug reference_branch=selected_reference_branch %}
+              {% include "common/metric_card.html" with slug=branch.slug reference_branch=selected_reference_branch %}
+
+            </div>
+          </div>
+        {% endfor %}


I wish we can find better solution for this

moibra05 requested review from freshstrangemusic, jaredlockhart and yashikakhurana as code owners November 3, 2025 19:30

moibra05 added the preview Create Preview Environment label Nov 3, 2025

moibra05 force-pushed the 13720 branch from 219baa8 to 9de80b6 Compare November 3, 2025 19:32

moibra05 enabled auto-merge November 3, 2025 19:55

yashikakhurana reviewed Nov 4, 2025

View reviewed changes

experimenter/experimenter/nimbus_ui/templates/nimbus_experiments/results-new.html Outdated Show resolved Hide resolved

moibra05 force-pushed the 13720 branch from e240ca0 to f4af76c Compare November 4, 2025 17:35

moibra05 requested a review from yashikakhurana November 4, 2025 17:36

yashikakhurana reviewed Nov 4, 2025

View reviewed changes

feat(nimbus): create filters for updated results page

40edddf

moibra05 force-pushed the 13720 branch from f4af76c to 40edddf Compare November 5, 2025 15:45

moibra05 requested a review from yashikakhurana November 5, 2025 17:03

yashikakhurana approved these changes Nov 5, 2025

View reviewed changes

moibra05 added this pull request to the merge queue Nov 5, 2025

Merged via the queue into main with commit 5c39b81 Nov 5, 2025
18 checks passed

moibra05 deleted the 13720 branch November 5, 2025 20:28

Conversation

moibra05 commented Nov 3, 2025

Uh oh!

moibra05 commented Nov 3, 2025

Uh oh!

mozcloud-preview-environments bot commented Nov 3, 2025

Uh oh!

mozcloud-preview-environments bot commented Nov 3, 2025

Uh oh!

mozcloud-preview-environments bot commented Nov 3, 2025

Uh oh!

mozcloud-preview-environments bot commented Nov 3, 2025

Uh oh!

yashikakhurana left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mozcloud-preview-environments bot commented Nov 4, 2025

Uh oh!

mozcloud-preview-environments bot commented Nov 4, 2025

Uh oh!

yashikakhurana left a comment

Choose a reason for hiding this comment

Uh oh!

yashikakhurana Nov 4, 2025

Choose a reason for hiding this comment

Uh oh!

moibra05 Nov 5, 2025

Choose a reason for hiding this comment

Uh oh!

moibra05 Nov 5, 2025

Choose a reason for hiding this comment

Uh oh!

mozcloud-preview-environments bot commented Nov 5, 2025

Uh oh!

mozcloud-preview-environments bot commented Nov 5, 2025

Uh oh!

mozcloud-preview-environments bot commented Nov 5, 2025

Uh oh!

yashikakhurana left a comment

Choose a reason for hiding this comment

Uh oh!

yashikakhurana Nov 5, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants