Skip to content

fix(nimbus): Fix feature changes table data persisting on app change.#13879

Merged
b4handjr merged 2 commits intomainfrom
fix-13877
Nov 4, 2025
Merged

fix(nimbus): Fix feature changes table data persisting on app change.#13879
b4handjr merged 2 commits intomainfrom
fix-13877

Conversation

@b4handjr
Copy link
Contributor

@b4handjr b4handjr commented Nov 3, 2025 •
edited
Loading

Because

  • We uncovered a bug in which the feature changes table on the feature health page would persist data after loading and the user selecting another application.

This commit

  • Only loads the feature schemas table if there is a valid and existing queryset.

Fixes #13877

@yashikakhurana yashikakhurana added the preview Create Preview Environment label Nov 3, 2025
@mozcloud-preview-environments
Copy link

mozcloud-preview-environments bot commented Nov 3, 2025

Preview environment has been deployed.

Preview URL: https://pr13879-experimenter.preview.mozilla.cloud

It may take up to 5 minutes for the environment to become available.
If the link doesn't work immediately, please wait a few moments and try again.

You can monitor deployment status in Argo CD.

1 similar comment
@mozcloud-preview-environments
Copy link

mozcloud-preview-environments bot commented Nov 3, 2025

Preview environment has been deployed.

Preview URL: https://pr13879-experimenter.preview.mozilla.cloud

It may take up to 5 minutes for the environment to become available.
If the link doesn't work immediately, please wait a few moments and try again.

You can monitor deployment status in Argo CD.

@mozcloud-preview-environments
Copy link

mozcloud-preview-environments bot commented Nov 4, 2025

Preview environment has been deployed.

Preview URL: https://pr13879-experimenter.preview.mozilla.cloud

It may take up to 5 minutes for the environment to become available.
If the link doesn't work immediately, please wait a few moments and try again.

You can monitor deployment status in Argo CD.

1 similar comment
@mozcloud-preview-environments
Copy link

mozcloud-preview-environments bot commented Nov 4, 2025

Preview environment has been deployed.

Preview URL: https://pr13879-experimenter.preview.mozilla.cloud

It may take up to 5 minutes for the environment to become available.
If the link doesn't work immediately, please wait a few moments and try again.

You can monitor deployment status in Argo CD.

yashikakhurana
yashikakhurana requested changes Nov 4, 2025
View reviewed changes
Copy link
Contributor

@yashikakhurana yashikakhurana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @b4handjr can you add a test for this use case of the bug so that we are covering this 🙏

experimenter/experimenter/nimbus_ui/views.py
total_changes = 0

if feature_id:
if feature_id and qs:
Copy link
Contributor

@yashikakhurana yashikakhurana Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a test related to this scenario 🙏

@b4handjr b4handjr force-pushed the fix-13877 branch 2 times, most recently from ac84fe1 to 60b5f9b Compare November 4, 2025 15:48
@mozcloud-preview-environments
Copy link

mozcloud-preview-environments bot commented Nov 4, 2025

Preview environment has been deployed.

Preview URL: https://pr13879-experimenter.preview.mozilla.cloud

It may take up to 5 minutes for the environment to become available.
If the link doesn't work immediately, please wait a few moments and try again.

You can monitor deployment status in Argo CD.

@mozcloud-preview-environments
Copy link

mozcloud-preview-environments bot commented Nov 4, 2025

Preview environment has been deployed.

Preview URL: https://pr13879-experimenter.preview.mozilla.cloud

It may take up to 5 minutes for the environment to become available.
If the link doesn't work immediately, please wait a few moments and try again.

You can monitor deployment status in Argo CD.

1 similar comment
@mozcloud-preview-environments
Copy link

mozcloud-preview-environments bot commented Nov 4, 2025

Preview environment has been deployed.

Preview URL: https://pr13879-experimenter.preview.mozilla.cloud

It may take up to 5 minutes for the environment to become available.
If the link doesn't work immediately, please wait a few moments and try again.

You can monitor deployment status in Argo CD.

yashikakhurana
yashikakhurana approved these changes Nov 4, 2025
View reviewed changes
Copy link
Contributor

@yashikakhurana yashikakhurana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @b4handjr tested locally bug is no longer reproducible

@b4handjr b4handjr added this pull request to the merge queue Nov 4, 2025
Merged via the queue into main with commit 6bb82d4 Nov 4, 2025
18 checks passed
@b4handjr b4handjr deleted the fix-13877 branch November 4, 2025 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yashikakhurana yashikakhurana yashikakhurana approved these changes

@jaredlockhart jaredlockhart Awaiting requested review from jaredlockhart jaredlockhart is a code owner

@freshstrangemusic freshstrangemusic Awaiting requested review from freshstrangemusic freshstrangemusic is a code owner

Assignees

No one assigned

Labels

preview Create Preview Environment

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Feature changes table does not reset when application is changed

2 participants

@b4handjr @yashikakhurana