feat(nimbus): Add subscribed feature experiments to home view.#13934
Merged
yashikakhurana merged 3 commits intomainfrom Nov 13, 2025
Merged
feat(nimbus): Add subscribed feature experiments to home view.#13934yashikakhurana merged 3 commits intomainfrom
yashikakhurana merged 3 commits intomainfrom
Conversation
b4handjr
added
pr-preview
preview
b4handjr
requested review from
freshstrangemusic,
jaredlockhart and
yashikakhurana
as code owners
yashikakhurana
requested changes
Nov 11, 2025
| slug="feature-subscribe", name="Feature Subscribe" | ||
| ) | ||
| feature.subscribers.add(self.user) | ||
| feature.refresh_from_db() |
Contributor
There was a problem hiding this comment.
you probably dont need refersh here
b4handjr
force-pushed
the
fix-13890-1
branch
from
edaf447 to
49a1274
Compare
yashikakhurana
requested changes
Nov 12, 2025
| @@ -354,6 +354,7 @@ class MyDeliveriesChoices(models.TextChoices): | |||
| ALL = "AllDeliveries", "All My Deliveries" | |||
| OWNED = "AllOwned", "All Owned" | |||
| SUBSCRIBED = "AllSubscribed", "All Subscribed" | |||
Contributor
There was a problem hiding this comment.
I meant to only change revert the All deliveries one, can you rename all subscribed to all subscribed deliveries please
| slug="feature-subscribe", name="Feature Subscribe" | ||
| ) | ||
| subscribed_feature.subscribers.add(self.user) | ||
| subscribed_feature.refresh_from_db() |
Contributor
There was a problem hiding this comment.
you have another refresh here too which you probably don't need it
yashikakhurana
approved these changes
Nov 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
This commit
Fixes #13890