chore(nimbus): use rust jexl evaluator in all tests#13957
Merged
jaredlockhart merged 1 commit intomainfrom Nov 17, 2025
Merged
Conversation
jaredlockhart
requested review from
freshstrangemusic and
yashikakhurana
as code owners
Collaborator
Author
|
Blocked on #13948 |
Contributor
|
@jaredlockhart oh you got that 💯 , I started looking at this morning, Thank you 🙏 |
yashikakhurana
approved these changes
Nov 17, 2025
Contributor
yashikakhurana
left a comment
yashikakhurana
left a comment
There was a problem hiding this comment.
Perfect, thanks @jaredlockhart more intact test cases
Becuase * We recently saw a case where we added a jexl expression that was valid in desktop but not in the sdk * The tests used the python jexl evaluator which does not exactly match the behaviur of the rust one used in the sdk * We have access to the rust evaluator so we can use it to validate jexl expressions in all the tests This commit * Adds a validate jexl function that uses both the python evaluator and optionally the rust evaluator for non desktop expressions * Updates all the jexl validation tests to use it * This was checked and would have caught the recent regression fixes #13956
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Becuase
This commit
fixes #13956