feat(nimbus): Send emails to feature subscribers#13988
Merged
yashikakhurana merged 7 commits intomainfrom Nov 19, 2025
Merged
Conversation
yashikakhurana
requested review from
freshstrangemusic and
jaredlockhart
as code owners
jaredlockhart
approved these changes
Nov 19, 2025
Collaborator
jaredlockhart
left a comment
jaredlockhart
left a comment
There was a problem hiding this comment.
Yep perfect, great use of set, great test coverage, 💯 A+ 10/10 thnx @yashikakhurana
Comment on lines
+145
to
+149
| self.assertIn(experiment.owner.email, sent_email.recipients()) | ||
| self.assertIn(experiment_subscriber.email, sent_email.cc) | ||
| self.assertIn(feature_subscriber1.email, sent_email.cc) | ||
| self.assertIn(feature_subscriber2.email, sent_email.cc) | ||
| self.assertEqual(len(sent_email.cc), 3) |
| self.assertIn(feature_subscriber2.email, sent_email.cc) | ||
| self.assertEqual(len(sent_email.cc), 3) | ||
|
|
||
| def test_send_experiment_ending_email_deduplicates_subscribers(self): |
Comment on lines
+39
to
51
| emails = chain( | ||
| experiment.feature_configs.values_list("subscribers__email", flat=True), | ||
| experiment.subscribers.values_list("email", flat=True), | ||
| ) | ||
| cc_emails = {email for email in emails if email} | ||
|
|
||
| email = EmailMessage( | ||
| subject.format(name=experiment.name), | ||
| content, | ||
| settings.EMAIL_SENDER, | ||
| [experiment.owner.email], | ||
| cc=experiment.subscribers.all().values_list("email", flat=True), | ||
| cc=list(cc_emails), | ||
| ) |
Collaborator
There was a problem hiding this comment.
Yep definitely exactly 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
This commit
Fixes #13937