feat(nimbus): cache users in NimbusExperimentChangeLogInline#13991
Merged
freshstrangemusic merged 1 commit intomainfrom Nov 19, 2025
Merged
feat(nimbus): cache users in NimbusExperimentChangeLogInline#13991freshstrangemusic merged 1 commit intomainfrom
freshstrangemusic merged 1 commit intomainfrom
Conversation
freshstrangemusic
requested review from
jaredlockhart and
yashikakhurana
as code owners
freshstrangemusic
force-pushed
the
push-uzzpuswpkqtp
branch
3 times, most recently
from
2f03ebd to
745db42
Compare
freshstrangemusic
changed the title
Member
Author
yeah probably. |
freshstrangemusic
force-pushed
the
push-uzzpuswpkqtp
branch
from
745db42 to
0465f61
Compare
Because: - the changelog admin inline queries all users for each changelog; and - we now have many more changelogs than we previously had, which has resulted in the admin page for experiments becoming unusable this commit: - computes the list of users once and uses the same list for all changelog inlines, reducing the number of User model queries from O(N) to O(1). Fixes #13990
freshstrangemusic
force-pushed
the
push-uzzpuswpkqtp
branch
from
0465f61 to
31a25b3
Compare
relud
approved these changes
Nov 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because:
this commit:
changelog inlines, reducing the number of User model queries from O(N)
to O(1).
Fixes #13990