Skip to content

Comments

feat(nimbus): Update advanced targeting for OLD_SIDEBAR_USERS to exclude users without a sidebar-button#14012

Merged
jaredlockhart merged 3 commits intomozilla:mainfrom
nikk15:update-sidebar-targeting-b
Nov 21, 2025
Merged

feat(nimbus): Update advanced targeting for OLD_SIDEBAR_USERS to exclude users without a sidebar-button#14012
jaredlockhart merged 3 commits intomozilla:mainfrom
nikk15:update-sidebar-targeting-b

Conversation

@nikk15
Copy link
Contributor

@nikk15 nikk15 commented Nov 20, 2025

Because

  • We need to exclude users without a sidebar button in their toolbar as it is needed to anchor the callout.

This commit

  • Updates advanced targeting for OLD_SIDEBAR_USERS_V2

@freshstrangemusic freshstrangemusic changed the title feat(nimbus): Update advanced targeting for OLD_SIDEBAR_USERS to excl… feat(nimbus): Update advanced targeting for OLD_SIDEBAR_USERS to exclude users without a sidebar-button Nov 20, 2025
@freshstrangemusic
Copy link
Member

Please make code_format or, if you have pipx installed, pipx run ruff -- format ./experimenter/experimenter/targeting/constants.py

Copy link
Collaborator

@jaredlockhart jaredlockhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep looks good thnx @nikk15 👍

@jaredlockhart jaredlockhart added this pull request to the merge queue Nov 21, 2025
Merged via the queue into mozilla:main with commit d4dfd52 Nov 21, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants