bug(nimbus): line wrap readonly codemirrors#14049
Merged
jaredlockhart merged 2 commits intomainfrom Nov 25, 2025
Merged
Conversation
Becuase * Long strings inside JSON values like feature values or JEXL targeting can cause the read only codemirrors to be too wide This commit * Moves all read only codemirror setup into a single file * Adds the codemirror linewrapping extension * Updates the outer element styling to account for fixed width fixes #13977
jaredlockhart
requested review from
freshstrangemusic and
yashikakhurana
as code owners
Collaborator
Author
|
yashikakhurana
approved these changes
Nov 25, 2025
Contributor
yashikakhurana
left a comment
yashikakhurana
left a comment
There was a problem hiding this comment.
Tested locally, works great. thanks @jaredlockhart
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Becuase
This commit
fixes #13977