feat(nimbus): create update leading branch image forms by moibra05 · Pull Request #14086 · mozilla/experimenter

moibra05 · 2025-11-28T17:34:07Z

Because

Gives user the ability to change the first image associated with a branch after the experiment has already started

This commit

Gives each branch a modal form that allows the first branch image to be changed

Fixes #14015

moibra05 · 2025-11-28T17:34:43Z

yashikakhurana · 2025-11-28T19:32:56Z

experimenter/experimenter/nimbus_ui/views.py

+        form.save()
+        resp = HttpResponse()
+        resp.headers["HX-Refresh"] = "true"
+        return resp
+


oh instead of refreshing the whole page, we can use hx-target and hx-swap

will be addressed in a future pr b/c closing modals after submitting forms is a little more complicated #14094

yashikakhurana

In general implementation looks good, just one minor suggestion. Thank you @moibra05

mozcloud-preview-environments · 2025-11-28T21:19:44Z

Preview environment has been deployed.

Preview URL: https://pr14086-experimenter.preview.mozilla.cloud

It may take up to 5 minutes for the environment to become available.
If the link doesn't work immediately, please wait a few moments and try again.

You can monitor deployment status in Argo CD.

yashikakhurana

Thank you @moibra05 some small suggestions to improve, overall its coming good together

experimenter/experimenter/nimbus_ui/forms.py

experimenter/experimenter/nimbus_ui/views.py

experimenter/experimenter/nimbus_ui/templates/common/branch_card.html

experimenter/experimenter/nimbus_ui/views.py

experimenter/experimenter/nimbus_ui/tests/test_forms.py

experimenter/experimenter/nimbus_ui/templates/common/branch_card.html

mozcloud-preview-environments · 2025-12-05T00:20:05Z

Preview environment has been deployed.

Preview URL: https://pr14086-experimenter.preview.mozilla.cloud

It may take up to 5 minutes for the environment to become available.
If the link doesn't work immediately, please wait a few moments and try again.

You can monitor deployment status in Argo CD.

mozcloud-preview-environments · 2025-12-05T00:25:24Z

Preview environment has been deployed.

Preview URL: https://pr14086-experimenter.preview.mozilla.cloud

It may take up to 5 minutes for the environment to become available.
If the link doesn't work immediately, please wait a few moments and try again.

You can monitor deployment status in Argo CD.

mozcloud-preview-environments · 2025-12-08T21:19:26Z

Preview environment has been deployed.

Preview URL: https://pr14086-experimenter.preview.mozilla.cloud

It may take up to 5 minutes for the environment to become available.
If the link doesn't work immediately, please wait a few moments and try again.

You can monitor deployment status in Argo CD.

mozcloud-preview-environments · 2025-12-08T21:24:58Z

Preview environment has been deployed.

Preview URL: https://pr14086-experimenter.preview.mozilla.cloud

It may take up to 5 minutes for the environment to become available.
If the link doesn't work immediately, please wait a few moments and try again.

You can monitor deployment status in Argo CD.

mozcloud-preview-environments · 2025-12-09T15:43:54Z

Preview environment has been deployed.

Preview URL: https://pr14086-experimenter.preview.mozilla.cloud

It may take up to 5 minutes for the environment to become available.
If the link doesn't work immediately, please wait a few moments and try again.

You can monitor deployment status in Argo CD.

mozcloud-preview-environments · 2025-12-09T20:19:26Z

Preview environment has been deployed.

Preview URL: https://pr14086-experimenter.preview.mozilla.cloud

It may take up to 5 minutes for the environment to become available.
If the link doesn't work immediately, please wait a few moments and try again.

You can monitor deployment status in Argo CD.

mozcloud-preview-environments · 2025-12-09T20:24:57Z

Preview environment has been deployed.

Preview URL: https://pr14086-experimenter.preview.mozilla.cloud

It may take up to 5 minutes for the environment to become available.
If the link doesn't work immediately, please wait a few moments and try again.

You can monitor deployment status in Argo CD.

mozcloud-preview-environments · 2025-12-10T19:07:42Z

Preview environment has been deployed.

Preview URL: https://pr14086-experimenter.preview.mozilla.cloud

It may take up to 5 minutes for the environment to become available.
If the link doesn't work immediately, please wait a few moments and try again.

You can monitor deployment status in Argo CD.

mozcloud-preview-environments · 2025-12-10T19:12:53Z

Preview environment has been deployed.

Preview URL: https://pr14086-experimenter.preview.mozilla.cloud

It may take up to 5 minutes for the environment to become available.
If the link doesn't work immediately, please wait a few moments and try again.

You can monitor deployment status in Argo CD.

yashikakhurana

Thank you @moibra05 tested locally, and using pr-preview mode, looks good to me, great job getting this done 🎉

mozcloud-preview-environments · 2025-12-10T19:28:59Z

Preview environment has been deployed.

Preview URL: https://pr14086-experimenter.preview.mozilla.cloud

It may take up to 5 minutes for the environment to become available.
If the link doesn't work immediately, please wait a few moments and try again.

You can monitor deployment status in Argo CD.

mozcloud-preview-environments · 2025-12-10T19:34:30Z

Preview environment has been deployed.

Preview URL: https://pr14086-experimenter.preview.mozilla.cloud

It may take up to 5 minutes for the environment to become available.
If the link doesn't work immediately, please wait a few moments and try again.

You can monitor deployment status in Argo CD.

made changes

moibra05 requested review from freshstrangemusic, jaredlockhart and yashikakhurana as code owners November 28, 2025 17:34

moibra05 added preview Create Preview Environment pr-preview and removed preview Create Preview Environment labels Nov 28, 2025

yashikakhurana reviewed Nov 28, 2025

View reviewed changes

moibra05 added the preview Create Preview Environment label Nov 28, 2025

moibra05 requested a review from yashikakhurana December 1, 2025 18:04

yashikakhurana requested changes Dec 3, 2025

View reviewed changes

experimenter/experimenter/nimbus_ui/forms.py Outdated Show resolved Hide resolved

experimenter/experimenter/nimbus_ui/views.py Outdated Show resolved Hide resolved

freshstrangemusic previously requested changes Dec 3, 2025

View reviewed changes

moibra05 force-pushed the 14015 branch from 081b030 to 7084fb6 Compare December 8, 2025 21:09

moibra05 force-pushed the 14015 branch 2 times, most recently from 0c53ac9 to 5453223 Compare December 9, 2025 15:34

moibra05 requested review from freshstrangemusic and yashikakhurana December 9, 2025 15:35

moibra05 force-pushed the 14015 branch from 5453223 to 465a892 Compare December 10, 2025 18:57

feat(nimbus): create update leading branch image forms

ffe2fcf

moibra05 force-pushed the 14015 branch from 465a892 to ffe2fcf Compare December 10, 2025 19:15

yashikakhurana approved these changes Dec 10, 2025

View reviewed changes

moibra05 enabled auto-merge December 11, 2025 15:56

moibra05 added this pull request to the merge queue Dec 11, 2025

Merged via the queue into main with commit 6c945b1 Dec 11, 2025
18 checks passed

moibra05 deleted the 14015 branch December 11, 2025 16:18

Comments

Conversation

moibra05 commented Nov 28, 2025

Uh oh!

moibra05 commented Nov 28, 2025

Uh oh!

yashikakhurana Nov 28, 2025

Choose a reason for hiding this comment

Uh oh!

moibra05 Dec 1, 2025

Choose a reason for hiding this comment

Uh oh!

yashikakhurana left a comment

Choose a reason for hiding this comment

Uh oh!

mozcloud-preview-environments bot commented Nov 28, 2025

Uh oh!

yashikakhurana left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mozcloud-preview-environments bot commented Dec 5, 2025

Uh oh!

mozcloud-preview-environments bot commented Dec 5, 2025

Uh oh!

mozcloud-preview-environments bot commented Dec 8, 2025

Uh oh!

mozcloud-preview-environments bot commented Dec 8, 2025

Uh oh!

mozcloud-preview-environments bot commented Dec 9, 2025

Uh oh!

mozcloud-preview-environments bot commented Dec 9, 2025

Uh oh!

mozcloud-preview-environments bot commented Dec 9, 2025

Uh oh!

mozcloud-preview-environments bot commented Dec 10, 2025

Uh oh!

mozcloud-preview-environments bot commented Dec 10, 2025

Uh oh!

yashikakhurana left a comment

Choose a reason for hiding this comment

Uh oh!

mozcloud-preview-environments bot commented Dec 10, 2025

Uh oh!

mozcloud-preview-environments bot commented Dec 10, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants