Skip to content

Comments

feat(nimbus): create timeline view for experiments in enrollment and observation phases#14105

Merged
moibra05 merged 1 commit intomainfrom
14089
Jan 5, 2026
Merged

feat(nimbus): create timeline view for experiments in enrollment and observation phases#14105
moibra05 merged 1 commit intomainfrom
14089

Conversation

@moibra05
Copy link
Contributor

@moibra05 moibra05 commented Dec 2, 2025

Because

  • New results page should be viewable while an experiment is still enrolling as well as observing

This commit

  • Creates a timeline card that shows how far along an experiment is in the enrollment and observation stages
  • Enrollment can be closed and experiments can be ended early from this results page

Fixes #14089

@moibra05 moibra05 added Blocked preview Create Preview Environment labels Dec 2, 2025
@moibra05
Copy link
Contributor Author

moibra05 commented Dec 2, 2025 •
edited
Loading

image image image image image

@moibra05 moibra05 force-pushed the 14089 branch 2 times, most recently from 03f64e8 to c571115 Compare December 3, 2025 16:06
@mozcloud-preview-environments
Copy link

mozcloud-preview-environments bot commented Dec 3, 2025

Preview environment has been deployed.

Preview URL: https://pr14105-experimenter.preview.mozilla.cloud

It may take up to 5 minutes for the environment to become available.
If the link doesn't work immediately, please wait a few moments and try again.

You can monitor deployment status in Argo CD.

yashikakhurana
yashikakhurana requested changes Dec 3, 2025
View reviewed changes
Copy link
Contributor

@yashikakhurana yashikakhurana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @moibra05, We have all the launch controls here-

experimenter/experimenter/experimenter/nimbus_ui/templates/nimbus_experiments/launch_controls.html

Line 143 in 89253e4

{% elif experiment.is_preview %}
I think we can reuse this in the page and if its require little modification we can do that in launch controls so timeline is same across all the pages

experimenter/experimenter/nimbus_ui/templates/nimbus_experiments/launch_controls_v2.html
@@ -0,0 +1,192 @@
{% load nimbus_extras %}
Copy link
Contributor

@yashikakhurana yashikakhurana Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can use the launch controls to show the progress 🤔

Copy link
Member

@freshstrangemusic freshstrangemusic Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should perhaps have a launch_controls_v2 since the Figma design uses different wording and has additional buttons in some cases.

Copy link
Contributor

@yashikakhurana yashikakhurana Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right and then we can just replace that once we have complete new ui

freshstrangemusic
freshstrangemusic reviewed Dec 3, 2025
View reviewed changes
Copy link
Member

@freshstrangemusic freshstrangemusic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ill hold off on a full review until its mergeable

@mozcloud-preview-environments
Copy link

mozcloud-preview-environments bot commented Dec 4, 2025

Preview environment has been deployed.

Preview URL: https://pr14105-experimenter.preview.mozilla.cloud

It may take up to 5 minutes for the environment to become available.
If the link doesn't work immediately, please wait a few moments and try again.

You can monitor deployment status in Argo CD.

4 similar comments
@mozcloud-preview-environments
Copy link

mozcloud-preview-environments bot commented Dec 5, 2025

Preview environment has been deployed.

Preview URL: https://pr14105-experimenter.preview.mozilla.cloud

It may take up to 5 minutes for the environment to become available.
If the link doesn't work immediately, please wait a few moments and try again.

You can monitor deployment status in Argo CD.

@mozcloud-preview-environments
Copy link

mozcloud-preview-environments bot commented Dec 5, 2025

Preview environment has been deployed.

Preview URL: https://pr14105-experimenter.preview.mozilla.cloud

It may take up to 5 minutes for the environment to become available.
If the link doesn't work immediately, please wait a few moments and try again.

You can monitor deployment status in Argo CD.

@mozcloud-preview-environments
Copy link

mozcloud-preview-environments bot commented Dec 9, 2025

Preview environment has been deployed.

Preview URL: https://pr14105-experimenter.preview.mozilla.cloud

It may take up to 5 minutes for the environment to become available.
If the link doesn't work immediately, please wait a few moments and try again.

You can monitor deployment status in Argo CD.

@mozcloud-preview-environments
Copy link

mozcloud-preview-environments bot commented Dec 9, 2025

Preview environment has been deployed.

Preview URL: https://pr14105-experimenter.preview.mozilla.cloud

It may take up to 5 minutes for the environment to become available.
If the link doesn't work immediately, please wait a few moments and try again.

You can monitor deployment status in Argo CD.

yashikakhurana
yashikakhurana requested changes Dec 10, 2025
View reviewed changes
@mozcloud-preview-environments
Copy link

mozcloud-preview-environments bot commented Dec 12, 2025

Preview environment has been deployed.

Preview URL: https://pr14105-experimenter.preview.mozilla.cloud

It may take up to 5 minutes for the environment to become available.
If the link doesn't work immediately, please wait a few moments and try again.

You can monitor deployment status in Argo CD.

1 similar comment
@mozcloud-preview-environments
Copy link

mozcloud-preview-environments bot commented Dec 12, 2025

Preview environment has been deployed.

Preview URL: https://pr14105-experimenter.preview.mozilla.cloud

It may take up to 5 minutes for the environment to become available.
If the link doesn't work immediately, please wait a few moments and try again.

You can monitor deployment status in Argo CD.

@mozcloud-preview-environments
Copy link

mozcloud-preview-environments bot commented Dec 12, 2025

Preview environment has been deployed.

Preview URL: https://pr14105-experimenter.preview.mozilla.cloud

It may take up to 5 minutes for the environment to become available.
If the link doesn't work immediately, please wait a few moments and try again.

You can monitor deployment status in Argo CD.

@mozcloud-preview-environments
Copy link

mozcloud-preview-environments bot commented Dec 15, 2025

Preview environment has been deployed.

Preview URL: https://pr14105-experimenter.preview.mozilla.cloud

It may take up to 5 minutes for the environment to become available.
If the link doesn't work immediately, please wait a few moments and try again.

You can monitor deployment status in Argo CD.

1 similar comment
@mozcloud-preview-environments
Copy link

mozcloud-preview-environments bot commented Dec 15, 2025

Preview environment has been deployed.

Preview URL: https://pr14105-experimenter.preview.mozilla.cloud

It may take up to 5 minutes for the environment to become available.
If the link doesn't work immediately, please wait a few moments and try again.

You can monitor deployment status in Argo CD.

yashikakhurana
yashikakhurana approved these changes Dec 18, 2025
View reviewed changes
Copy link
Contributor

@yashikakhurana yashikakhurana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @moibra05 looks good to me

@mozcloud-preview-environments
Copy link

mozcloud-preview-environments bot commented Dec 18, 2025

Preview environment has been deployed.

Preview URL: https://pr14105-experimenter.preview.mozilla.cloud

It may take up to 5 minutes for the environment to become available.
If the link doesn't work immediately, please wait a few moments and try again.

You can monitor deployment status in Argo CD.

1 similar comment
@mozcloud-preview-environments
Copy link

mozcloud-preview-environments bot commented Dec 18, 2025

Preview environment has been deployed.

Preview URL: https://pr14105-experimenter.preview.mozilla.cloud

It may take up to 5 minutes for the environment to become available.
If the link doesn't work immediately, please wait a few moments and try again.

You can monitor deployment status in Argo CD.

freshstrangemusic
freshstrangemusic requested changes Dec 18, 2025
View reviewed changes
@mozcloud-preview-environments
Copy link

mozcloud-preview-environments bot commented Dec 18, 2025

Preview environment has been deployed.

Preview URL: https://pr14105-experimenter.preview.mozilla.cloud

It may take up to 5 minutes for the environment to become available.
If the link doesn't work immediately, please wait a few moments and try again.

You can monitor deployment status in Argo CD.

1 similar comment
@mozcloud-preview-environments
Copy link

mozcloud-preview-environments bot commented Dec 18, 2025

Preview environment has been deployed.

Preview URL: https://pr14105-experimenter.preview.mozilla.cloud

It may take up to 5 minutes for the environment to become available.
If the link doesn't work immediately, please wait a few moments and try again.

You can monitor deployment status in Argo CD.

@mozcloud-preview-environments
Copy link

mozcloud-preview-environments bot commented Dec 19, 2025

Preview environment has been deployed.

Preview URL: https://pr14105-experimenter.preview.mozilla.cloud

It may take up to 5 minutes for the environment to become available.
If the link doesn't work immediately, please wait a few moments and try again.

You can monitor deployment status in Argo CD.

1 similar comment
@mozcloud-preview-environments
Copy link

mozcloud-preview-environments bot commented Dec 19, 2025

Preview environment has been deployed.

Preview URL: https://pr14105-experimenter.preview.mozilla.cloud

It may take up to 5 minutes for the environment to become available.
If the link doesn't work immediately, please wait a few moments and try again.

You can monitor deployment status in Argo CD.

@mozcloud-preview-environments
Copy link

mozcloud-preview-environments bot commented Dec 19, 2025

Preview environment has been deployed.

Preview URL: https://pr14105-experimenter.preview.mozilla.cloud

It may take up to 5 minutes for the environment to become available.
If the link doesn't work immediately, please wait a few moments and try again.

You can monitor deployment status in Argo CD.

1 similar comment
@mozcloud-preview-environments
Copy link

mozcloud-preview-environments bot commented Dec 19, 2025

Preview environment has been deployed.

Preview URL: https://pr14105-experimenter.preview.mozilla.cloud

It may take up to 5 minutes for the environment to become available.
If the link doesn't work immediately, please wait a few moments and try again.

You can monitor deployment status in Argo CD.

@mozcloud-preview-environments
Copy link

mozcloud-preview-environments bot commented Dec 19, 2025

Preview environment has been deployed.

Preview URL: https://pr14105-experimenter.preview.mozilla.cloud

It may take up to 5 minutes for the environment to become available.
If the link doesn't work immediately, please wait a few moments and try again.

You can monitor deployment status in Argo CD.

@mozcloud-preview-environments
Copy link

mozcloud-preview-environments bot commented Dec 19, 2025

Preview environment has been deployed.

Preview URL: https://pr14105-experimenter.preview.mozilla.cloud

It may take up to 5 minutes for the environment to become available.
If the link doesn't work immediately, please wait a few moments and try again.

You can monitor deployment status in Argo CD.

1 similar comment
@mozcloud-preview-environments
Copy link

mozcloud-preview-environments bot commented Dec 19, 2025

Preview environment has been deployed.

Preview URL: https://pr14105-experimenter.preview.mozilla.cloud

It may take up to 5 minutes for the environment to become available.
If the link doesn't work immediately, please wait a few moments and try again.

You can monitor deployment status in Argo CD.

@moibra05 moibra05 added this pull request to the merge queue Jan 5, 2026
Merged via the queue into main with commit ce8ece4 Jan 5, 2026
19 checks passed
@moibra05 moibra05 deleted the 14089 branch January 5, 2026 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@freshstrangemusic freshstrangemusic freshstrangemusic approved these changes

@yashikakhurana yashikakhurana yashikakhurana approved these changes

@jaredlockhart jaredlockhart Awaiting requested review from jaredlockhart jaredlockhart is a code owner

Assignees

No one assigned

Labels

pr-preview preview Create Preview Environment

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add a timeline interface to the new results page

4 participants

@moibra05 @freshstrangemusic @yashikakhurana @jaredlockhart