feat(nimbus): only log jetstream fetches on new data#14171
Merged
jaredlockhart merged 1 commit intomainfrom Dec 11, 2025
Merged
feat(nimbus): only log jetstream fetches on new data#14171jaredlockhart merged 1 commit intomainfrom
jaredlockhart merged 1 commit intomainfrom
Conversation
jaredlockhart
requested review from
freshstrangemusic and
yashikakhurana
as code owners
mikewilli
reviewed
Dec 10, 2025
experimenter/experimenter/experiments/migrations/0305_delete_jetstream_changelogs.py
Show resolved
Hide resolved
| from django.db import migrations | ||
|
|
||
|
|
||
| def delete_results_fetched_changelogs(apps, _schema_editor): |
Contributor
There was a problem hiding this comment.
This isn't going to clear out all the changelogs whenever the migration gets applied, right?
Collaborator
Author
There was a problem hiding this comment.
Migrations run only once, so it'll happen once, we'll lose all the jetstream changelogs from the last few weeks, and then start getting filled in from land time forward.
Becuase * We recently added changelogs on jetstream fetches to improve visibility on successful or failed jetstream fetches * We logged on every fetch attempt, so many unnecessary changelogs were created * Large numbers of changelogs can cause pages to load slowly or not at all * We only need to log if the data has changed This commit * Deletes all existing jetstream fetch changelogs * Updates the logic to only create a changelog if the results data changed fixes #14163
mikewilli
approved these changes
Dec 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Becuase
This commit
fixes #14163