Conversation
moibra05
requested review from
freshstrangemusic,
jaredlockhart and
yashikakhurana
as code owners
Contributor
Author
|
yashikakhurana
requested changes
Dec 12, 2025
Contributor
yashikakhurana
left a comment
yashikakhurana
left a comment
There was a problem hiding this comment.
Thank you @moibra05 couple of suggestions and one question. Overall nice job
| "widget_tweaks", | ||
| "fontawesomefree", | ||
| "django_bootstrap5", | ||
| "django_summernote", |
Contributor
There was a problem hiding this comment.
why this dependency?
Contributor
Author
There was a problem hiding this comment.
Summernote provides the rich text editor
Contributor
Author
There was a problem hiding this comment.
Its one of the few rich text editors i found with mit licensing and has django support
Contributor
There was a problem hiding this comment.
I like the editor, good find
yashikakhurana
requested changes
Dec 16, 2025
experimenter/experimenter/nimbus_ui/templates/common/edit_outcome_summary_form.html
Outdated
Show resolved
Hide resolved
| "widget_tweaks", | ||
| "fontawesomefree", | ||
| "django_bootstrap5", | ||
| "django_summernote", |
Contributor
There was a problem hiding this comment.
I like the editor, good find
moibra05
force-pushed
the
13726
branch
2 times, most recently
from
4e6cba2 to
ddc59bc
Compare
yashikakhurana
requested changes
Dec 16, 2025
experimenter/experimenter/nimbus_ui/templatetags/nimbus_extras.py
Outdated
Show resolved
Hide resolved
Comment on lines
+194
to
+207
| PROJECT_IMPACT_SUBTITLES = { | ||
| NimbusConstants.ProjectImpact.HIGH: ( | ||
| "Moved key company metrics or made visible progress toward " | ||
| "broader goals. Worth sharing across teams or with leadership." | ||
| ), | ||
| NimbusConstants.ProjectImpact.MODERATE: ( | ||
| "Provided meaningful progress or insights, with impact more " | ||
| "localized than company-wide." | ||
| ), | ||
| NimbusConstants.ProjectImpact.TARGETED: ( | ||
| "Met intended goals and delivered useful learnings, though " | ||
| "it didn't shift broader metrics." | ||
| ), | ||
| } |
Contributor
There was a problem hiding this comment.
May be you just want to keep this and remove the other one
moibra05
force-pushed
the
13726
branch
2 times, most recently
from
1b71d26 to
ca915d8
Compare
moibra05
force-pushed
the
13726
branch
2 times, most recently
from
e685951 to
f6a7a04
Compare
yashikakhurana
approved these changes
Dec 18, 2025
Contributor
yashikakhurana
left a comment
yashikakhurana
left a comment
There was a problem hiding this comment.
Thank you @moibra05 looks good to me!! nice editor find
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
This commit
Fixes #13726