chore(nimbus): readonly changelogs in admin#14197
Merged
yashikakhurana merged 1 commit intomainfrom Dec 16, 2025
Merged
Conversation
jaredlockhart
requested review from
freshstrangemusic and
yashikakhurana
as code owners
Collaborator
Author
|
yashikakhurana
approved these changes
Dec 16, 2025
Contributor
yashikakhurana
left a comment
yashikakhurana
left a comment
There was a problem hiding this comment.
readable data 👀 , thank you @jaredlockhart
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
Becuase * We had inline formsets for changelogs in the admin * These are very slow to render especially for experiments with lots of changes * We don't actually need to be able to edit changelogs in the admin, they really should be read only * We can just display their values for reference purpose in the admin, this should be much faster to render This commit * Replaces NimbusExperimentAdmin changelog inline formsets with a read only table fixes #14164
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Becuase
This commit
fixes #14164