feat(nimbus): QA testplan and testrail links#14214
Merged
yashikakhurana merged 4 commits intomainfrom Dec 17, 2025
Merged
Conversation
Contributor
Author
Collaborator
|
And fields that store urls should probably be labeled as such ie |
jaredlockhart
previously requested changes
Dec 16, 2025
Collaborator
jaredlockhart
left a comment
There was a problem hiding this comment.
Also probably want to update the tests to include setting/checking the new fields as well 🙏
Contributor
Author
jaredlockhart
approved these changes
Dec 17, 2025
Collaborator
jaredlockhart
left a comment
There was a problem hiding this comment.
Yep tested locally, all works perfectly. Well written changes, great test coverage. Great job ty @yashikakhurana 🙏 🎉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Because
This commit
Fixes #14158
Fixes #14159