Skip to content

Comments

feat(nimbus): Add prefix channel name in the slack DM message#14218

Merged
yashikakhurana merged 3 commits intomainfrom
14215
Dec 18, 2025
Merged

feat(nimbus): Add prefix channel name in the slack DM message#14218
yashikakhurana merged 3 commits intomainfrom
14215

Conversation

@yashikakhurana
Copy link
Contributor

Because

  • We are sending DMs to the user if they are not in the channel about the slack message, but we are not including the channel name to promote them to join the channel

This commit

  • Adds the channel name in the message

Fixes #14215

Copy link
Collaborator

@jaredlockhart jaredlockhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't there tests?

@yashikakhurana
Copy link
Contributor Author

Aren't there tests?
yup there are, my bad, skipped to commit that file

Copy link
Collaborator

@jaredlockhart jaredlockhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice ty @yashikakhurana 🙏

@yashikakhurana yashikakhurana added this pull request to the merge queue Dec 18, 2025
Merged via the queue into main with commit a5a14a1 Dec 18, 2025
17 checks passed
@yashikakhurana yashikakhurana deleted the 14215 branch December 18, 2025 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add prefix as the channel name in the DM message

2 participants