Skip to content

Comments

bug(nimbus): dont log results error changes#14226

Merged
jaredlockhart merged 1 commit intomainfrom
14068
Dec 18, 2025
Merged

bug(nimbus): dont log results error changes#14226
jaredlockhart merged 1 commit intomainfrom
14068

Conversation

@jaredlockhart
Copy link
Collaborator

Becuase

  • We want to log jetstream fetches to make it easier to inspect and debug when jetstream data updates
  • We also don't want to log many duplicate fetches when no data has changed
  • The errors fields include timetamps that bump on every fetch causing duplicate changelogs

This commit

  • Deletes existing duplicate jetstream fetch changelogs
  • Strips errors when comparing jetstream data

fixes #14068

Copy link
Contributor

@yashikakhurana yashikakhurana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets go, more improvements 🎉 Thank you @jaredlockhart

@jaredlockhart jaredlockhart added this pull request to the merge queue Dec 18, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 18, 2025
@jaredlockhart jaredlockhart added this pull request to the merge queue Dec 18, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 18, 2025
Becuase

* We want to log jetstream fetches to make it easier to inspect and debug when jetstream data updates
* We also don't want to log many duplicate fetches when no data has changed
* The errors fields include timetamps that bump on every fetch causing duplicate changelogs

This commit

* Deletes existing duplicate jetstream fetch changelogs
* Strips errors when comparing jetstream data

fixes #14068
@jaredlockhart jaredlockhart added this pull request to the merge queue Dec 18, 2025
Merged via the queue into main with commit 12524f7 Dec 18, 2025
17 checks passed
@jaredlockhart jaredlockhart deleted the 14068 branch December 18, 2025 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Too many irrellevant changelogs are created

2 participants