Bug-2017254: Handle null signatures for PerfCompareResults#9254
Open
moijes12 wants to merge 1 commit intomozilla:masterfrom
Open
Bug-2017254: Handle null signatures for PerfCompareResults#9254moijes12 wants to merge 1 commit intomozilla:masterfrom
moijes12 wants to merge 1 commit intomozilla:masterfrom
Conversation
Added validators to map `null` to `None` if `null` is passed for base or parent signatures in api call to PerfCompareResults.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
PerfCompareand no crashes or traceback was displayed to the end user.Analysis
PerfCompareto Treeherder's perfcompare/results api endpoint were returning Server Error 500base_parent_signatureornew_parent_signatureparameter was set tonullnew_parent_signaturewas set tonullin the caller.nullto be passed for signatures. The signatures are defined as CharFields. @Archaeopteryx @camd : Why is the field created as Charfield while the signatures in other serializers for the Performance data are defined as Integerfield ? What was the reasoning behind it ?nullresults in an error as it expects as integer. Thenullis also not mapped toNone.Proposed Fix
Added validators to map
nulltoNoneifnullis passed for base or parent signatures in api call to PerfCompareResults.Fixes Bug-2017254
@Archaeopteryx @kala-moz @gmierz @beatrice-acasandrei