fix: set pulse_job origin kind and owner correctly#9265
Open
ahal wants to merge 1 commit intomozilla:masterfrom
Open
fix: set pulse_job origin kind and owner correctly#9265ahal wants to merge 1 commit intomozilla:masterfrom
ahal wants to merge 1 commit intomozilla:masterfrom
Conversation
Previously we were setting these based solely on the Taskcluster route, based on whether the project has a `/` in it or not. This is obviously incorrect and I suspect nearly all pulse_job events emitted for Github repos contain incorrect origin and have missing owner. I don't think this was causing any problems, but wanted to clean it up prior to a larger refactor in this area.
Member
Author
|
The lint issue appears to be pre-existing (I can repro on master) For testing I spun on a local instance and confirmed pushes and tasks were being processed and were showing up in the UI. I'm not sure if there's additional testing I should do or not though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we were setting these based solely on the Taskcluster route, based on whether the project has a
/in it or not. This is obviously incorrect and I suspect nearly all pulse_job events emitted for Github repos contain incorrect origin and have missing owner.I don't think this was causing any problems, but wanted to clean it up prior to a larger refactor in this area.