Fix connection.parse.js test for node-mqtt-packet 7.1.1#29
Open
grandpaul wants to merge 1 commit intomqttjs:masterfrom
Open
Fix connection.parse.js test for node-mqtt-packet 7.1.1#29grandpaul wants to merge 1 commit intomqttjs:masterfrom
grandpaul wants to merge 1 commit intomqttjs:masterfrom
Conversation
If we set incorrect flags / qos, node-mqtt-packet 7.1.1 will emit an error exception and thus fail the tests. This commit fixes those failed tests. Signed-off-by: Ying-Chun Liu (PaulLiu) <paulliu@debian.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we set incorrect flags / qos, node-mqtt-packet 7.1.1 will
emit an error exception and thus fail the tests. This commit
fixes those failed tests.
Signed-off-by: Ying-Chun Liu (PaulLiu) paulliu@debian.org
The test fail log is at https://ci.debian.net/data/autopkgtest/unstable/amd64/n/node-mqtt-connection/17702033/log.gz
Please review this patch and see if it is correct. Thanks.