fix: Initialize CoreML delegate options to enable all devices#165
Open
anarsultanov wants to merge 1 commit intomrousavy:mainfrom
Open
fix: Initialize CoreML delegate options to enable all devices#165anarsultanov wants to merge 1 commit intomrousavy:mainfrom
anarsultanov wants to merge 1 commit intomrousavy:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TfLiteCoreMlDelegateOptionswas declared without any initialization, leaving all its fields (enabled_devices,coreml_version,max_delegated_partitions,min_nodes_per_partition) with indeterminate values. This could cause unpredictable behavior when creating the CoreML delegate.Unlike the NNAPI and Android GPU delegates which use explicit
*Default()initializer functions, the CoreML delegate API doesn't provide one. This fix initializes the struct withTfLiteCoreMlDelegateAllDevicesforenabled_devices(so the delegate works on any device that supports CoreML, not just those with a Neural Engine), while zero-initializing the remaining fields, which the delegate creation function handles with sensible internal defaults.