fix: Make sure that camera is initialized when querying devices#3704
Open
ldalzottomp wants to merge 1 commit intomrousavy:mainfrom
Open
fix: Make sure that camera is initialized when querying devices#3704ldalzottomp wants to merge 1 commit intomrousavy:mainfrom
ldalzottomp wants to merge 1 commit intomrousavy:mainfrom
Conversation
|
@ldalzottomp is attempting to deploy a commit to the mrousavy's Team Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This PR fixes user reports where android app shows no camera at all by changing how android initialization is done.
Changes
Note: RNVC = React Native Vision Camera
The root cause was:
This leads to a scenario where:
This PR fixes this behaviour and makes sure that camera structure are initialized when demanded by awaiting the initialization task. We keep starting the initialzation as early as possible.
Here is an image of init log with additional lines:
The issue is super easy to reproduce. On any app, introduce an artificial delay before extensionsManager = ExtensionsManager.getInstanceAsync(reactContext, cameraProvider!!).await(executor)
Tested on
Google Pixel 7 : Android 16.
Related issues