feat(ios): remove simulator camera restriction#3707
Open
yocontra wants to merge 1 commit intomrousavy:mainfrom
Open
feat(ios): remove simulator camera restriction#3707yocontra wants to merge 1 commit intomrousavy:mainfrom
yocontra wants to merge 1 commit intomrousavy:mainfrom
Conversation
|
@yocontra is attempting to deploy a commit to the mrousavy's Team Team on Vercel. A member of the Team first needs to authorize it. |
Remove the compile-time check that throws `notAvailableOnSimulator` error on iOS simulators. This enables camera functionality with tools like RocketSim that provide virtual camera support in the iOS Simulator. Also removes the now-unused `DeviceError.notAvailableOnSimulator` case.
yocontra
force-pushed
the
feat/support-simulator-camera
branch
from
b9bc101 to
51c9ed2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#if targetEnvironment(simulator)check that throwsCameraError.device(.notAvailableOnSimulator)DeviceError.notAvailableOnSimulatorerror caseMotivation
Tools like RocketSim now support virtual cameras in the iOS Simulator, making it possible to test camera functionality without a physical device. The current restriction prevents this useful development workflow.
Test plan