feat(parser): add support for env inline comments#512
Open
Rickyc81 wants to merge 1 commit intomrsteele:masterfrom
Open
feat(parser): add support for env inline comments#512Rickyc81 wants to merge 1 commit intomrsteele:masterfrom
Rickyc81 wants to merge 1 commit intomrsteele:masterfrom
Conversation
mrsteele
requested changes
Jan 15, 2026
Owner
mrsteele
left a comment
mrsteele
left a comment
There was a problem hiding this comment.
Thanks for this! It's really great and I like it!
One request - Can we add unit tests that cover this requirement? I don't want to support this and accidentally break it along the way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows dotenv-webpack to accept inline comments like this:
PORT=8080 #8081 8082
In this case, everything after # will be excluded from the value.
fix #507