arm64: boot: dts: qcom: msm8939-asus-z00t: add charger and USB-OTG#426
Draft
erikas9987 wants to merge 2 commits intomsm8916-mainline:wip/msm8916/6.19-rc6from
Draft
arm64: boot: dts: qcom: msm8939-asus-z00t: add charger and USB-OTG#426erikas9987 wants to merge 2 commits intomsm8916-mainline:wip/msm8916/6.19-rc6from
erikas9987 wants to merge 2 commits intomsm8916-mainline:wip/msm8916/6.19-rc6from
Conversation
This device uses Summit SMB358 as its charging IC. This commit adds the device tree configuration for it and adds additional properties for the battery. Signed-off-by: Erikas Bitovtas <xerikasxx@gmail.com>
This device has GPIO 121 set as its OTG gpio. This commit adds a pin configuration node to an existing USB extcon for it. Signed-off-by: Erikas Bitovtas <xerikasxx@gmail.com>
Author
|
Currently unplugging the device from a charging source will cause the battery to keep reporting as charging. Does anyone know why? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds the Summit SMB358 charging IC and the USB-OTG GPIO powered by its VBUS regulator.
Unfortunately, due to how heavily the device driver is modified in downstream, the contents of this PR are just an attempt to match the register set as close as it's possible.
The value for
constant-charge-voltage-max-microvoltcan be found here (downstream says 4380mV but we round it to 4400mV so theclamp_valfunction in mainline driver can properly set the bits)The value for
constant-charge-current-max-microampcan be found here (ASUS actually sets different fast charge values for ZE551KL and ZD551KL, but LineageOS downstream has merged their configurations and confirmed it works either way)The value for
charge-term-current-microampcan be found hereThe value for
operating-range-celsiuswas taken from a downstream kernel register dump, I couldn't find where in the driver code it was being set.The value for
summit,charge-current-compensation-microampcan be foundhere
The value for
summit,enable-charge-controlcan be found here (ASUS actually toggles this in the driver, but the comment says it's only needed for Asus Fonepad, so this is more of a guess)summit,soft-compensation-modeis taken from here, but this function is not being called anywhere in the driver...Currently charging is capped to 1A as a safety measure.