fix(WebSocket): resolve relative connection urls#763
Merged
kettanaito merged 3 commits intomainfrom Feb 6, 2026
Merged
Conversation
Member
Author
|
The nock compatibility test suite must be suffering from some caching since locally compat tests pass: Or it might be mistakingly running on Node.js v24, which we don't currently support. |
Member
Author
Released: v0.41.1 🎉This has been released in v0.41.1. Get these changes by running the following command: Predictable release automation by Release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed we were not following the WebSocket constructor spec and did not resolve relative connection URLs if run in the browser context. There was also no protocol replacement logic either.