additional functionality for gridify.m#442
Open
vtvivian wants to merge 1 commit intomtex-toolbox:developfrom
Open
additional functionality for gridify.m#442vtvivian wants to merge 1 commit intomtex-toolbox:developfrom
vtvivian wants to merge 1 commit intomtex-toolbox:developfrom
Conversation
added squarify2 function, which allows step size to be defined explicitly (ebsdGrid.dx) instead of auto calculated this sometimes leads to seam artefacts in ebsdGrid output, so all elements in ebsdgrid are assigned the nearest ebsd datapoint to remove these seams, with no interpolation of orientation data.
Member
ralfHielscher
left a comment
ralfHielscher
left a comment
There was a problem hiding this comment.
Hi Vivian,
thank you for contributing to MTEX. Your functions squarify2 shares many code lines with squarify. In general it is preferable to avoid code duplication as it make maintenance of the code more hard. Maybe you could add setting the unit cell as an option to quarify.
Ralf.
ralfHielscher
force-pushed
the
develop
branch
from
ceaf790 to
2094f05
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added squarify2 function, which allows step size to be defined explicitly (ebsdGrid.dx) instead of auto calculated
this sometimes leads to seam artefacts in ebsdGrid output, so all elements in ebsdgrid are assigned the nearest ebsd datapoint to remove these seams, with no interpolation of orientation data.